-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proxy settings #8019
Support proxy settings #8019
Conversation
integrations-core/datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/http.py Line 13 in e36ccba
|
fc3893c
to
3036ac1
Compare
Codecov Report
|
LGTM once the log nit is fixed |
Why can we perform queries outside of the lock? There’s no proxy once the connection is established? |
The method is overridden permanently for the connection created within the lock |
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 docs
What does this PR do?
This PR introduces a workaround to add proxy support to Snowflake.
Currently, Snowflake python connector supports proxy by setting environment variables
HTTP_PROXY
/HTTPS_PROXY
/NO_PROXY
. We want to avoid using this as these configuration settings will affect other services and the integration will not be using proxy settings specified in the Agent.https://docs.snowflake.com/en/user-guide/python-connector-example.html#using-a-proxy-server
This PR also removes the min_collection config in the code since we don't use this at the check level.
Motivation
There is an upstream PR for this fix
https://github.com/snowflakedb/snowflake-connector-python/pull/352
.We can remove the workaround once the fix is available.
Additional Notes
Manually tested with squid proxy
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached