Use spec template #8192

coignetp · 2020-12-14T11:16:40Z

QA

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached

codecov · 2020-12-14T11:29:18Z

Codecov Report

Merging #8192 (dbe4cdf) into master (9cf3a3a) will decrease coverage by 7.09%.
The diff coverage is n/a.

Impacted Files	Coverage Δ
datadog_checks_dev/tests/conftest.py
php_fpm/datadog_checks/php_fpm/php_fpm.py
http_check/datadog_checks/http_check/__init__.py
datadog_checks_dev/datadog_checks/dev/_env.py
activemq/tests/test_check.py
network/datadog_checks/network/__init__.py
couchbase/datadog_checks/couchbase/__init__.py
cassandra_nodetool/tests/test_unit.py
process/tests/conftest.py
mysql/datadog_checks/mysql/const.py
... and 838 more

kafka_consumer/datadog_checks/kafka_consumer/data/conf.yaml.example

apigirl

👍 docs are fine

Use spec template

dbe4cdf

coignetp requested review from a team as code owners December 14, 2020 11:16

ghost added documentation integration/kafka_consumer labels Dec 14, 2020

hithwen added the changelog/no-changelog label Dec 14, 2020

hithwen reviewed Dec 14, 2020

View reviewed changes

kafka_consumer/datadog_checks/kafka_consumer/data/conf.yaml.example Show resolved Hide resolved

hithwen removed the changelog/no-changelog label Dec 14, 2020

coignetp added the changelog/Fixed label Dec 14, 2020

ChristineTChen approved these changes Dec 14, 2020

View reviewed changes

apigirl approved these changes Dec 14, 2020

View reviewed changes

coignetp merged commit 20f1e6a into master Dec 15, 2020

coignetp deleted the paul/qa-kc-specs branch December 15, 2020 16:00

ChristineTChen pushed a commit that referenced this pull request Dec 15, 2020

Use spec template (#8192)

d639356