Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging #8795

Merged
merged 1 commit into from
Mar 15, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,20 @@ def check(self, instance):
instance.get('kafka_consumer_offsets', self._zk_hosts_ports is None)
):
try:
self.log.debug('Collecting consumer offsets')
self._get_kafka_consumer_offsets(contexts_limit)
contexts_limit -= len(self._kafka_consumer_offsets)
except Exception:
self.log.exception("There was a problem collecting consumer offsets from Kafka.")
# don't raise because we might get valid broker offsets
else:
self.log.debug(
'Identified api_version: %s, kafka_consumer_offsets: %s, zk_connection_string: %s.'
' Skipping consumer offset collection',
str(self._kafka_client.config.get('api_version') >= (0, 8, 2)),
str(instance.get('kafka_consumer_offsets')),
str(self._zk_hosts_ports),
)

# Fetch the broker highwater offsets
try:
Expand Down