Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redisdb: correct default ssl_cert_reqs #9048

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

wbobeirne
Copy link
Contributor

What does this PR do?

Fixes the config.yaml documentation to correctly show that the default when not specifying ssl_cert_reqs is 2 (require)

Motivation

I was getting SSL errors that I didn't expect when adding a configuration for redis on Heroku, since Heroku requires you not verify the self-signed certificates they use for Redis. After some digging, I realized that the actual default for ssl_cert_reqs is to require them: https://redis-py.readthedocs.io/en/stable/#redis.Redis

Additional Notes

N/A

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@wbobeirne wbobeirne requested review from a team as code owners March 27, 2021 23:26
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants