Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make critical service checks more verbose #9280

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Make critical service checks more verbose #9280

merged 2 commits into from
Jun 9, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Refactored service checks to submit OK in else clause. Add error message to critical service checks.

Motivation

Improve usability

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner May 3, 2021 22:23
@ghost ghost added the integration/redisdb label May 3, 2021
@ChristineTChen
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #9280 (a35a9fd) into master (371b02a) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Flag Coverage Δ
redisdb 86.97% <80.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
redisdb/datadog_checks/redisdb/redisdb.py 74.72% <80.00%> (+0.08%) ⬆️

@ChristineTChen ChristineTChen merged commit 85e7488 into master Jun 9, 2021
@ChristineTChen ChristineTChen deleted the cc/refactor-redis-sc branch June 9, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/redisdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristineTChen @ofek