Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obfuscator options being converted into bytes rather than string #9676

Merged

Conversation

alexbarksdale
Copy link
Member

What does this PR do?

Fixes obfuscator options being converted into bytes rather than string. Error found:

2021-07-12 17:14:20 UTC | CORE | WARN | (pkg/collector/python/datadog_agent.go:124 in LogMessage) | mysql:c94166e47fbb1ecc | (statements.py:190) | Failed to obfuscate query 'SELECT ?': argument 2 must be str, not bytes

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #9676 (5b33a18) into master (c94ba90) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 85.27% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorianVeaux FlorianVeaux merged commit 552e037 into master Jul 13, 2021
@FlorianVeaux FlorianVeaux deleted the alex.barksdale/mysql-fix-obfuscate-options-not-being-str branch July 13, 2021 07:46
FlorianVeaux pushed a commit that referenced this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants