Updated httpd_check to include new attributes. #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for skip_event,check_certificate_expiration,days_warning,days_critical
|
Sorry for the multple PR's, finally got this one right and it passed the checks. This should be good to go, has the spec test, and works well on several of my production sites. Thanks! |
|
Thank you very much @aepod! Very much appreciated, kudos for updating the tests. This looks good! 🙇 |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
* Update http_check.yaml.erb * Updated httpd check to include several variables Added support for skip_event,check_certificate_expiration,days_warning,days_critical * Updated puppet code for addition attributes. * Formatting fixes * Deplurilazation * Update http_check.yaml.erb * Added Spec for http_check additions * Update datadog_agent_integrations_http_check_spec.rb * Update http_check.yaml.erb * Fixed trailing whitespace issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for new attributes in the http_check
skip_event is needed to squelch the following error
Warning: Using events for service checks is deprecated in favor of monitors and will be removed in future versions of the Datadog Agent.
check_certificate_expiration is used for checking the validity of certificates and has the following two options. (days_warning and days_critical)
More info on these:
https://github.com/DataDog/dd-agent/blob/master/conf.d/http_check.yaml.example