-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update v19 for Public Review #666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tolerance factor was changed from 2 to 3 to avoid picking up more reclassification errors.
- remove openpyxl to use Arelle requirement, which is pegged at 2.*
Reflects changes provided for Sonny based on negative interest rates being reported by banks.
- Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places
- add tests for dqc_0131
- dqc_0084 and dqc_0093
- v19.0.0RC4 from campbellpryde-xule.dqc
The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items.
Removed rule 9760 as it can be negative.
- filter for dqc_0047 and dqc_0081 edits
davidtauriello
added a commit
that referenced
this pull request
Sep 29, 2022
* Added V19 version * Create DQC_0138.xule Added rule 138 * Added rule 138 for Banking metrics * Added V19 compiled rules * Updated V19 esef rules * Updated rule 127 to handle large real estate instance documents * Updated rule 135 for quarterly reports * Updated rule 127 to handle large real estate schedules and updated 135 to handle quarterly reports. 135 - Quarterly Reports 127 - Large Real Estate Documents * Updated rule 84 message * Update DQC_0127.xule * Update DQC_0127.xule * Updated version number * Eliminated duplication in calc of constant cubes * Removed ; from constants file * Updated V18 with all changes * Updated rules to improve performance for REITS * Updated V19 * Update .travis.yml - filter for xule change impacts * Update .travis.yml - filter for revised rules 0084 and 0127 * Update V18 for public exposure (#644) * Updated rule 127 to handle large real estate schedules and updated 135 to handle quarterly reports. 135 - Quarterly Reports 127 - Large Real Estate Documents * Updated rule 84 message * Update DQC_0127.xule * Updated version number * Eliminated duplication in calc of constant cubes * Removed ; from constants file * Updated V18 with all changes * Update .travis.yml - filter for xule change impacts * Update .travis.yml - filter for revised rules 0084 and 0127 Co-authored-by: Campbell * Updated dimensions message so results are consistent * Updated for zip files * Updated and renamed V19 rules * Updated rules to include historical rules * Updated final V19 rules * Updated V19 ruleset. * Updated effective date files * Recompiled with updated resource file. * Reset .gitignore * Update documentation - add rule submission forms for dqc_0139, dqc_0140 and dqc_0141 * Update documentation - add rule submission forms for dqc_0139, dqc_0140 and dqc_0141 * Updated V19 rules to be more accurate. * Updated V19 rules * Corrected typo * Updated V19 for typo * Update v19test.xml * Update DQC_0140.md * Fixed xule issues in version 19 * Updated V19 to fix errors. * Updated for sort * updated V19 * Update .travis.yml and test cases for v19 * Update rulesets for v19 - rename v18 rulesets * Update rulesets for v19 - rename v18 rulesets * update .gitignore * Compared V18 to V10 and made consistent * Updated status for V19 * Added message update for rule 84 * Updated V19 for status * Update unit tests for v19 - changes from v18 - new for v19 * Update .travis.yml - run all tests * Added an income item to fix problem reported by Chad * Updated for Chads change. * Update constant.xule Removed elements that were not in the 2018 taxonomy. * Update v18 approved rule submission forms * Update v19 documentation - changes from v18 approved - rule forms for public review - updated rule form index * Updated taxonomy dates * Updated V19 * Updated V19 * Updated V19 * Updated error message for rule 139 to 100 percent. * Updated to fix rule message in 139 * Updated as part of rule message update * Updated rule 55 for foreign plan member guidance. * Updated version number on V19 * Update .travis.yml - filter for changes in v19.0.0RC2 - update dqc_0139.9855 for message change in rule submission form * Updated Tolerance factor for period comparison Tolerance factor was changed from 2 to 3 to avoid picking up more reclassification errors. * Update requirements.txt - remove openpyxl to use Arelle requirement, which is pegged at 2.* * Updated Non Neg for DQC Changes Reflects changes provided for Sonny based on negative interest rates being reported by banks. * updated rule 108 to take dimensions into account * Updated rule 131 to have a tolerance for decimal places * Updated version 19 release and resources * Updated all us-gaap resource files to V19 from V18. * Updated V19 * Update for v18 approved - Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places * Update .travis.yml for v18 approved - add tests for dqc_0131 * Update test cases for change in tolerance - dqc_0084 and dqc_0093 * Update .travis.yml for changes * Update v19 rulesets and resources * Update requirements.txt - remove openpyxl to use Arelle requirement, which is pegged at 2.* * Update for v18 approved - Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places * Update .travis.yml for v18 approved - add tests for dqc_0131 * Update test cases for change in tolerance - dqc_0084 and dqc_0093 * Update .travis.yml for changes * Update v19 rulesets and resources * Update rulesetMap.json * Updated Ruleset for iteration issue. * Update DQC_0081.xule * Updated version number * Updated V19 for iteration fix * Update .travis.yml * Update v19 for public review (#663) * Updated Ruleset for iteration issue. * Update DQC_0081.xule * Updated version number * Updated V19 for iteration fix * Update .travis.yml Co-authored-by: Campbell * Update ruleset .zip files - v19.0.0RC4 from campbellpryde-xule.dqc * Update ruleset .zip files - v19.0.0RC4 from campbellpryde-xule.dqc * Updated Rule 47 and 81 to handle BDC correctly The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items. * Update constant.xule * Update dqc_15_usgaap_2022_concepts.csv Removed rule 9760 as it can be negative. * Updated version number * Update resources.zip * Updated for CHanges for BDC * Update .travis.yml - filter for dqc_0047 and dqc_0081 edits * Update v19 for Public Review (#666) * Updated Rule 47 and 81 to handle BDC correctly The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items. * Update constant.xule * Update dqc_15_usgaap_2022_concepts.csv Removed rule 9760 as it can be negative. * Updated version number * Update resources.zip * Updated for CHanges for BDC * Update .travis.yml - filter for dqc_0047 and dqc_0081 edits Co-authored-by: Campbell * Update rulesetMap.json - remove 2022 IFRS http: namespace * Update rulesetMap.json - remove 2022 IFRS http: namespace * Update constant.xule Added InvestmentIdentifierAxis to allow non neg elements * Update base-taxonomy-2022.xule * Update namespace.xule * Update settings.json * Added FASB Taxonomies * Added todo items * Updated rule 118 to fix default issue Valid error were not flagging because the default dimension was not defined on the specific cube but was defined on another cube. As the default is not specific to a cube the rule was updated so if the default was defined for the dimension in any cube it would be recognized as the default * Updated rule 118 to work reliably The rule was not handling facts with multi dimensions in the addends. This fix resolves the issue so that results are consistent. * Updated changes for rule 118 * Update .travis.yml - add test case * Create DQC.US.0118.9575_maxd-us-2022.xml * Update dqc_0011.csv * Updated risk metrics for Buffer values * Update rule 141 to handle a reconciliation between interest and non interest * Updated V19 * Update DQC_011_ListOfElements.xlsx * Updated IFRS nonneg to be up to date. * Updated rule 81 to handle an empty set * Updated IFRS 128 for appropriate SRT * Updated IFRS for missing srt * Updated IFRS 128 for 2020 * Update .travis.yml - filter for changes v19.0.0RC6 - remove DQC.IFRS.0128.9598 - rdy-20210331.xml - revise dqc_0139 unit tests * Updated to fix typo * Updated 2020 IFRS to handle srt correctly * Updated V19 * Fix issue with rule 81 * Fixed rule 81 issue * Fixed missing comma in message. * Update .travis.yml - filter for dqc_0081 and dqc_0139 * Update namespace.xule * namespace update to V19 * Updated version info for V19 for approved release. * Remove old status parameters * Update rule submission forms and .travis.yml for approved * Update DQC.US.0139.9859_bhtbk-us-2021.xml - dqc_0139 message change * Update .travis.yml * Update for v19 Approved * Update unit tests for v19 - dqc_0011 - dqc_0080 * Update DQC.IFRS.0080_lbk-ifrs-2019.xml * Update DQC_0015_ListOfElements.xlsx * Update v19 Approved (#679) * Update unit tests for v19 - dqc_0011 - dqc_0080 * Update DQC.IFRS.0080_lbk-ifrs-2019.xml * Updated Data Quality Checks. Co-authored-by: Campbell
davidtauriello
added a commit
that referenced
this pull request
Nov 15, 2022
* Updated V20 rules * Updated rule 144 and 143 * Update requirements.txt - remove openpyxl to use Arelle requirement, which is pegged at 2.* * Updated Non Neg for DQC Changes Reflects changes provided for Sonny based on negative interest rates being reported by banks. * Updated Non Neg for DQC Changes Reflects changes provided for Sonny based on negative interest rates being reported by banks. * updated rule 108 to take dimensions into account * updated rule 108 to take dimensions into account * Updated rule 131 to have a tolerance for decimal places * Updated rule 131 to have a tolerance for decimal places * Updated version 19 release and resources * Updated all us-gaap resource files to V19 from V18. * Updated V19 * Update for v18 approved - Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places * Update .travis.yml for v18 approved - add tests for dqc_0131 * Update test cases for change in tolerance - dqc_0084 and dqc_0093 * Update .travis.yml for changes * Update v19 rulesets and resources * Update requirements.txt - remove openpyxl to use Arelle requirement, which is pegged at 2.* * Update for v18 approved - Updated Tolerance factor for period comparison - Updated Non Neg for DQC Changes - negative interest rates reported by banks - Updated rule 108 to take dimensions into account - Updated rule 131 to have a tolerance for decimal places * Update .travis.yml for v18 approved - add tests for dqc_0131 * Update test cases for change in tolerance - dqc_0084 and dqc_0093 * Update .travis.yml for changes * Update v19 rulesets and resources * Update rulesetMap.json * Updated Ruleset for iteration issue. * Updated Ruleset for iteration issue. * Update DQC_0081.xule * Updated version number * Updated V19 for iteration fix * Update .travis.yml * Update v19 for public review (#663) * Updated Ruleset for iteration issue. * Update DQC_0081.xule * Updated version number * Updated V19 for iteration fix * Update .travis.yml Co-authored-by: Campbell * Update ruleset .zip files - v19.0.0RC4 from campbellpryde-xule.dqc * Update ruleset .zip files - v19.0.0RC4 from campbellpryde-xule.dqc * Updated Rule 47 and 81 to handle BDC correctly The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items. * Update constant.xule * Updated Rule 47 and 81 to handle BDC correctly The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items. * Update dqc_15_usgaap_2022_concepts.csv Removed rule 9760 as it can be negative. * Update dqc_15_usgaap_2022_concepts.csv Removed rule 9760 as it can be negative. * Updated version number * Update resources.zip * Updated for CHanges for BDC * Update .travis.yml - filter for dqc_0047 and dqc_0081 edits * Update v19 for Public Review (#666) * Updated Rule 47 and 81 to handle BDC correctly The element InvestmentCompanyNetAssetsFromOperationsIncreaseDecrease is used as the starting point for the cash flow items for income. This was added to the list of income statement items. * Update constant.xule * Update dqc_15_usgaap_2022_concepts.csv Removed rule 9760 as it can be negative. * Updated version number * Update resources.zip * Updated for CHanges for BDC * Update .travis.yml - filter for dqc_0047 and dqc_0081 edits Co-authored-by: Campbell * Update rulesetMap.json - remove 2022 IFRS http: namespace * Update rulesetMap.json - remove 2022 IFRS http: namespace * Update constant.xule Added InvestmentIdentifierAxis to allow non neg elements * Update constant.xule Added InvestmentIdentifierAxis to allow non neg elements * Update base-taxonomy-2022.xule * Update namespace.xule * Update settings.json * Added FASB Taxonomies * Added todo items * Update DQC_0144.xule * Updated rule 118 to fix default issue Valid error were not flagging because the default dimension was not defined on the specific cube but was defined on another cube. As the default is not specific to a cube the rule was updated so if the default was defined for the dimension in any cube it would be recognized as the default * Updated rule 118 to fix default issue Valid error were not flagging because the default dimension was not defined on the specific cube but was defined on another cube. As the default is not specific to a cube the rule was updated so if the default was defined for the dimension in any cube it would be recognized as the default * Updated rule 118 to work reliably The rule was not handling facts with multi dimensions in the addends. This fix resolves the issue so that results are consistent. * Updated rule 118 to work reliably The rule was not handling facts with multi dimensions in the addends. This fix resolves the issue so that results are consistent. * Updated changes for rule 118 * Updated for 118 * Updated esef for 118 * Update .travis.yml - add test case * Create DQC.US.0118.9575_maxd-us-2022.xml * Update dqc_0011.csv * Updated risk metrics for Buffer values * Updated risk metrics for Buffer values * Update rule 141 to handle a reconciliation between interest and non interest * Update rule 141 to handle a reconciliation between interest and non interest * Updated V19 * Update DQC_011_ListOfElements.xlsx * Update for v18.0.6 DQC Approved * Update for ESEF-DQR for v2.0.2 (#4) * Update for v18.0.6 DQC Approved * Added additional rules * Added rules for V20 2022 * Updated for V20 Rules * Updated additional rules for V20 * Removed dup rules from 145 * Compiled version V20 * Added IFRS 2021 non neg and updated 0081 rule number * Updated IFRS nonneg to be up to date. * Updated IFRS nonneg to be up to date. * Update resources.xule * Update resources.xule * Updated V20 * Updated rule 81 to handle an empty set * Updated rule 81 to handle an empty set * Updated rule number on rule 81 * Updated IFRS for missing srt * Updated IFRS 128 for appropriate SRT * Updated IFRS 128 for 2020 * Update taxonomy Ref for ifrs 2020 * Updated IFRS 128 for appropriate SRT * Updated IFRS for missing srt * Updated IFRS 128 for 2020 * Update .travis.yml - filter for changes v19.0.0RC6 - remove DQC.IFRS.0128.9598 - rdy-20210331.xml - revise dqc_0139 unit tests * Updated to fix typo * Updated 2020 IFRS to handle srt correctly * Updated V19 * Fix issue with rule 81 * Fix issue with rule 81 * Fixed rule 81 issue * compiled V20 * Fixed missing comma in message. * Fixed missing comma in message. * Update .travis.yml - filter for dqc_0081 and dqc_0139 * Update namespace.xule * namespace update to V19 * Updated version info for V19 for approved release. * Remove old status parameters * Update rule submission forms and .travis.yml for approved * Update DQC.US.0139.9859_bhtbk-us-2021.xml - dqc_0139 message change * Update .travis.yml * Update for v19 Approved * Update unit tests for v19 - dqc_0011 - dqc_0080 * Update unit tests for v19 - dqc_0011 - dqc_0080 * Update DQC.IFRS.0080_lbk-ifrs-2019.xml * Update DQC.IFRS.0080_lbk-ifrs-2019.xml * Update DQC_0015_ListOfElements.xlsx * Updated Data Quality Checks. * Update v19 Approved (#679) * Update unit tests for v19 - dqc_0011 - dqc_0080 * Update DQC.IFRS.0080_lbk-ifrs-2019.xml * Updated Data Quality Checks. Co-authored-by: Campbell * Update .gitignore for xule.dqc * Update requirements.txt * Update .gitignore - remove /guidance * Update ruleset .zip files for v18.0.9 * Update for v19.0.0 approved * For IFRS taxonomy updated for Auditor Name Added auditor name for exceptions to rule 33 for IFRS. * For IFRS taxonomy updated for Auditor Name Added auditor name for exceptions to rule 33 for IFRS. * Updated rule 135 for tolerance * Update version.xule * Updated V19 Updated for change to 138 * Updated rule 132 to handle financ * Updated rule 132 to handle financ * Updated rule 135 for tolerance * Updated to handle pension issue for 135 * Updated version number * Updated V19 Updated for issue in rule 135. * Updated 136 to exclude nils * Updated to handle pension issue for 135 * Updated 136 to exclude nils * Updated V19 * Fixed message to show max absolute value. * Fixed message to show max absolute value. * Updated V19 for changes * Updated tolerance on 135 * Updated V20 rulesets * Updated tolerance to 20 * Updated for tolerance * Updated rule 134 for Short Term and Fixed Maturites Member * Updating Committing V19 * Updated rule 134 for Short Term and Fixed Maturites Member * Update dqc_0135 rule submission form * Updated V20 * Updated 140 to fix xule error * Update version.xule * Compiled V19 * Update requirements.txt and .travis.yml Update .travis.yml - add unit tests for dqc_0140 - update requirements for Arelle 2.0.0 Update requirements.txt Update requirements.txt Update travis-run.sh Update travis-run.sh Update travis-run.sh * Update unit tests for rule changes - dqc_0134, dqc_0135, dqc_0136 (add from v18) * Update v19 Approved (#682) * For IFRS taxonomy updated for Auditor Name Added auditor name for exceptions to rule 33 for IFRS. * Updated rule 135 for tolerance * Update version.xule * Updated V19 Updated for change to 138 * Updated rule 132 to handle financ * Updated to handle pension issue for 135 * Updated version number * Updated V19 Updated for issue in rule 135. * Updated 136 to exclude nils * Updated V19 * Fixed message to show max absolute value. * Updated V19 for changes * Updated tolerance to 20 * Updated for tolerance * Updated rule 134 for Short Term and Fixed Maturites Member * Updating Committing V19 * Update dqc_0135 rule submission form * Updated 140 to fix xule error * Update version.xule * Compiled V19 * Update requirements.txt and .travis.yml Update .travis.yml - add unit tests for dqc_0140 - update requirements for Arelle 2.0.0 Update requirements.txt Update requirements.txt Update travis-run.sh Update travis-run.sh Update travis-run.sh * Update unit tests for rule changes - dqc_0134, dqc_0135, dqc_0136 (add from v18) Co-authored-by: Campbell * Update .travis.yml * Update effective_dates.csv * Update resources.zip * Update effective_dates.csv Updated effective dates for V19 * Update effective_dates.csv Updated effective dates for V19 * Updated with effective dates in resource file * Update effective_dates.csv * Updated rule 145 for typo * Updated V20 * Updated rules for V20 * Updated V20 rules * Update .gitignore - XULE.DQC repo * Update from DQC v19.0.1 * Updated for unfunded on nonneg * Updated for unfunded on nonneg * Updated Version Number * Updated V19 version Number * Updated V20 Fixed XULE issues and added rule 148 * Updates to V20 * Fixed Tolerance scales and OVI issue on 135 * Fixed Tolerance scales and OVI issue on 135 * Updated to V20 rules so they work. * Updated for errors identified in V20 run * Updated rule 135 for OCI * Merge for v19.0.2 Approved (#686) * Updated for unfunded on nonneg * Fixed Tolerance scales and OVI issue on 135 * Updated rule 135 for OCI * Updated V19 for changes to 135 and Tolerance. Co-authored-by: Campbell Co-authored-by: marcward * Fixed rule 147 error message * Updated rule 0135 * Updated 135 * Merge for v19.0.2 (republish) (#688) * Fixed Tolerance scales and OVI issue on 135 - revise .xule, ruleset.zip and unit tests Co-authored-by: Campbell * Update V20 for V21 changes * Updated V20 rules to eliminate false positives for 145 and 146 * Updated 135 and 149 * Updated 146 to handle transitions. * Update functions.xule Updated functions to fix nested members issue. * Update DQC_0146.xule * Delete DQC_0149.xule Removed as belongs to version 21 * Updated V20 * Updated rule 118 * Updates to V18 for rule 118 * Updated V20 * Update v19 Approved (#692) * Update functions.xule Updated functions to fix nested members issue. * Updated version number * Updated V19 for member addition fix. * Update .travis.yml for dqc_0118 and dqc_0135 * Updated V19 for rule 118 changes Co-authored-by: Campbell Co-authored-by: marcward * Updated Resources for V20 and version number and status * Update resources.zip * Updated V20 * Update travis-CI for v20 rules * Update .travis.yml * Update documentation for v20 public exposure * Updated rule 146 for false value in boolean * Updated V20 for fix to 146 * Update resources.xule * Create tasks.json * Update dqc-ifrs-2021-V20-ruleset.zip * Update dqc-ifrs-2021-V20-ruleset.zip * Update DQC.US.0146.9870_form-us-2021.xml Co-authored-by: Campbell <campbell.pryde@xbrl.us> Co-authored-by: marcward <marc.ward@xbrl.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Pull request process
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.