Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ID not detected in minified JSON #1

Closed
neocortical opened this issue May 17, 2018 · 2 comments
Closed

Project ID not detected in minified JSON #1

neocortical opened this issue May 17, 2018 · 2 comments

Comments

@neocortical
Copy link

This regexp in client.go does not correctly extract the project ID from minified JSON:

projectExtractor = regexp.MustCompile(`"project_id": "([^"]+)",`)

Instead, it should be:

projectExtractor = regexp.MustCompile(`"project_id":\s*"([^"]+)",`)

Related: Why use regexp? Why not unmarshal the JSON object?

@klaidliadon
Copy link
Contributor

The regexp is 4 time faster and does not allocate any memory. Also, I do not need any of the other fields.

@klaidliadon
Copy link
Contributor

Fixed in: aa02a38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants