Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Error using CMake in Linux #134

Closed
tmarrinan opened this issue Feb 26, 2018 · 3 comments
Closed

Build Error using CMake in Linux #134

tmarrinan opened this issue Feb 26, 2018 · 3 comments
Labels

Comments

@tmarrinan
Copy link

I am getting the following error while configuring using CMake in Linux:

CMake Error at CMakeLists.txt:3 (if):
   if given arguments:

     "CMAKE_VERSION" "VERSION_GREATER_EQUAL" "3.0"

   Unknown arguments specified

I am using Linux Mint and have CMake version 3.5.1 installed.

@tmarrinan
Copy link
Author

A little extra digging turns up that VERSION_GREATER_EQUAL is not a valid comparison for CMake 3.5. There is only VERSION_GREATER up until CMake 3.7.

I believe the code could be changed to:

if (NOT CMAKE_VERSION VERSION_LESS 3.0)

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 27, 2018

Thanks, definitely a bug.

@Dav1dde Dav1dde added the bug label Feb 27, 2018
@Dav1dde
Copy link
Owner

Dav1dde commented Feb 27, 2018

Thanks again for the quick report, I tried with versions 3.0, 3.5 and 3.10 and all seem to work.

Interestingly enough, this issue didn't exist with CMake 3.10.

facebook-github-bot pushed a commit to pytorch/pytorch that referenced this issue Nov 6, 2020
Summary:
Bump condition check from >11.0 to >11.0.3

CMAKE 3.5 doesn't support VERSION_GREATER_EQUAL see [here](Dav1dde/glad#134), so we might need to bump this again iv 11.0.4+ releases.

should fix #47352

Pull Request resolved: #47408

Reviewed By: glaringlee

Differential Revision: D24759949

Pulled By: walterddr

fbshipit-source-id: de384c7b150babaf799cce53ed198e5e931899da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants