Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine rain and rainRate tile to get rid of $current.rain #147

Closed
gary-hammer opened this issue Apr 1, 2023 · 5 comments · Fixed by #156
Closed

Combine rain and rainRate tile to get rid of $current.rain #147

gary-hammer opened this issue Apr 1, 2023 · 5 comments · Fixed by #156
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@gary-hammer
Copy link

Describe the bug
Current rain does not display though the Today's total on the card does update.

To Reproduce
Have a steady rainfall.
4. See error

Expected behavior
Current rain should display.

Screenshots
2 screenshots during a thunderstorm. One from weewx-wdc one from Belchertown.

Screenshot 2023-04-01 19 35 23

Screenshot 2023-04-01 19 36 17

@gary-hammer gary-hammer added the bug Something isn't working label Apr 1, 2023
@gary-hammer
Copy link
Author

I think I know what is happening.
I do not have 'rain' as data. Davis uses rain_in for that.

I'm attaching MQTT data for both the Davis WiFi Logger and the Davis WeatherLinkLive
The system weewx-wdc is installed on uses the WLL.

So, if I want the displayed card to show 'Rain' and the proper value, what should be in the skin.conf?

Davis-mqtt-info.txt

@Daveiano
Copy link
Owner

Daveiano commented Apr 3, 2023

Current rain does not display though the Today's total on the card does update.

You mean the big '0.00 in' right above the 'Todays Total', right? Yeah, I also noticed this, this will very rarely go above 0.00. I looked through some code to understand what's happening here. So the skin uses this to render the stat tiles on the front page:

For eg. the outTemp: $current.outTemp, or the outHumidity: $current.outHumidity. For the rain, its the same: $current.rain. BUT: What is $current.rain? I assume in WeeWX terms its the rain observed during the last archive interval (just guessing) - but this is misleading and not very useful. The season skins also does not show this and only shows $day.rain.sum (the days total, see https://github.com/weewx/weewx/blob/master/skins/Seasons/current.inc#L32).

I would propose to remove the big '0.00 in' ($current.rain, since it does not make any useful sense) and instead combining the rain and rainRate tiles into one tile to show:

  • Todays rain total
  • current rain rate
  • Days max rain rate

What do you think about this?

@gary-hammer
Copy link
Author

I'd be happy with that, then I can just remove the rain rate tile.

@Daveiano
Copy link
Owner

Daveiano commented Apr 3, 2023

Ok then, I will have a look as soon as I got time, will be included in the next release!

@Daveiano Daveiano added this to the 3.2.0 milestone Apr 3, 2023
@gary-hammer
Copy link
Author

Thanks.
Look forward to the fix.

@Daveiano Daveiano added documentation Improvements or additions to documentation enhancement New feature or request and removed bug Something isn't working labels Apr 6, 2023
@Daveiano Daveiano changed the title [BUG] Rain Amount Not Updating Combine rain and rainRate tile to get rid of $current.rain Apr 6, 2023
@Daveiano Daveiano linked a pull request Apr 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants