Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diagrams configurable per context (per period) / Refactor diagrams configuration #73

Closed
Daveiano opened this issue Sep 22, 2022 · 0 comments · Fixed by #93
Closed
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@Daveiano
Copy link
Owner

Daveiano commented Sep 22, 2022

Currently, the skin only allows to define the diagrams once, this definition is then used on all pages (index, week, month, year, statistics). So it is not possible to show a specific diagram e.g. the outTemp min/max/avg diagram only on the statistics page. Every diagram is shown everywhere.

This should be configurable like in the default seasons skin [ImageGenerator] section:

[[day_images]]
        x_label_format = %H:%M
        bottom_label_format = %x %X
        time_length = 97200 # 27 hours
        
        [[[daybarometer]]]
            [[[[barometer]]]]
        
        [[[daytempdew]]]
            [[[[outTemp]]]]
            [[[[dewpoint]]]]
...
[[week_images]]
        x_label_format = %d
        bottom_label_format = %x %X
        time_length = 604800 # 7 days
        aggregate_type = avg
        aggregate_interval = hour
        
        [[[weekbarometer]]]
            [[[[barometer]]]]
        
        [[[weektempdew]]]
            [[[[outTemp]]]]
            [[[[dewpoint]]]]
...

Things to consider
- Refactor getDiagramProps methods to use weeutil.config.accumulateLeaves and search_up
- Expose enableArea and areaOpacity in skin.conf for diagrams

Related issues:
#25
#71
#75

@Daveiano Daveiano added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2022
@Daveiano Daveiano added this to the 3.0.0 milestone Sep 22, 2022
@Daveiano Daveiano changed the title Make diagrams configurable per context (per period) Make diagrams configurable per context (per period) / Refactor diagrams configuration Sep 22, 2022
@Daveiano Daveiano mentioned this issue Sep 24, 2022
7 tasks
@Daveiano Daveiano closed this as completed Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant