Refresh add-on to version 3.24 and upgrade dependencies #74
Conversation
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
from
c32eae6
to
01158c7
Compare
| - yarn lint | ||
| - yarn test:ember |
There was a problem hiding this comment.
- The initial npm-scripts
lint:hbsandlint:jscan be now called with the single npm-scriptlint - The initial npm-script
testused to triggerember test, we now have to call the npm-scripttest:ember
Also this is what is used in a fresh Ember add-on v3.24.
package.json in Ember v3.24
.travis.yml in Ember v3.24
| - stage: "Additional Tests" | ||
| name: "Floating Dependencies" | ||
| install: | ||
| - yarn install --no-lockfile | ||
| script: | ||
| - yarn test:ember |
There was a problem hiding this comment.
Why this new block? Because it exists when creating an add-on in v3.24:
|
I am changing the base branch from
|
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
from
01158c7
to
2957a33
Compare
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
2 times, most recently
from
d1d0d93
to
27fea9d
Compare
| @@ -1 +1 @@ | |||
| export { default, initialize } from 'ember-cli-embedded/initializers/embedded' | |||
| export { default, initialize } from 'ember-cli-embedded/initializers/embedded'; | |||
There was a problem hiding this comment.
I'm surprised by this kind of changes... Did it was intentionnal ? Did we have the pdoc linter setup in this project ? I'm surprise the linting does not complain about the ; & no new line at the end of the file....
There was a problem hiding this comment.
PeopleDoc lint config is currently not set up in this project:
https://github.com/peopledoc/ember-cli-embedded/blob/29637ee777a2ad60439ae5b060e1df524bbd98bf/package.json#L72-L78
And because of the TypeScript layer, we would even need to implement typescript-eslint, but as mentioned in the initial post: not now. After this PR sure the codebase would not be in a "perfect shape", we would have some inconsistencies...
There was a problem hiding this comment.
Here (the new ;), it was simply to comply to the current format/lint rules set up by the new version of ember-cli (hello Prettier).
I did not want to customise further the state of the PR, just a "take everything new from the recent version of ember-cli (so that the project runs on a solid and recent foundation), inject and renovate the code of the Initializers and the Service, done"
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
from
d6e98f5
to
18b4f24
Compare
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
from
f37415f
to
a24ed3c
Compare
- Restore first level of files from the root directory Every other files, in sub-directories `/addons` etc, will be handled separately. - TypeScript packages and related files NOT included Will be done separately
Restore root directories: - `/.github/` - `/config/` The rest of the directories will be restored/updated separately: - `/addon/` - `/app/` - `/tests/`
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
2 times, most recently
from
9475a96
to
8c006d9
Compare
In the add-on's documentation they recommend to edit the file `/ember-cli-build.js`: https://github.com/typed-ember/ember-cli-typescript/blob/4e4b161d55aae9d3409f7b7ad9630473af87109b/docs/configuration.md#enabling-sourcemaps But this is in the context of an application. Here, in the context of an add-on, this change must be done in the file `/index.js`: - typed-ember/ember-cli-typescript#1390 (comment) > ... I saw that the babel config for addons is not supposed to go in > `ember-cli-build.js` but in `index.js` - https://github.com/babel/ember-cli-babel/tree/88a8c8154e480cbbd01e96257c5a8097d6be79f1#options > There are a few different options that may be provided to > `ember-cli-babel`. These options are typically set in an apps > `ember-cli-build.js` file, or in an addon or engine's `index.js`.
MrChocolatine
force-pushed
the
release-v2--01-upgrade-ember-and-dependencies
branch
from
8c006d9
to
8fc3ceb
Compare
MrChocolatine
changed the title
ember-cli and dependencies
What?
This is the first pull request of an upcoming series.
The aim of this one is simply to "reuse the existing but upgrade the foundation".
Anything about customising lint, code styling, syntax, types etc will be dealt with later.
Several pull requests from @dependabot could be closed after this pull request.
Build
Refresh add-on to version 3.24 (#74)
In order to deeply upgrade the add-on, to have recent and solid foundations, the entire codebase has been reset as a fresh Ember add-on in version 3.24:
https://github.com/ember-cli/ember-addon-output/tree/v3.24.0
Then, the previous content has been imported, revamped and fixed, onto that upgraded codebase.
Among existing packages that have been upgraded, some have been replaced:
Deprecated package
ember-cli-uglifyreplaced byember-cli-terserDeprecated package
ember-cli-template-lintreplaced byember-template-lintUpgrade
ember-auto-import@1.11.3(#74)Upgrade
ember-cli-babel@7.26.5(#74)Upgrade
ember-cli-terser@4.0.2(#74)Upgrade
ember-source@3.26.1(#74)Upgrade
ember-template-lint@3.4.0(#74)Upgrade
eslint@7.25.0(#74)Upgrade
eslint-config-prettier@8.3.0(#74)Upgrade
eslint-plugin-ember@10.4.1(#74)Upgrade
ember-cli-typescript@4.1.0(#74)Enable TypeScript sourcemaps (#74)
Rebuild file
yarn.lock(#74)CI
Update Node.js version from 10 to 12 (#74)
Documentation
Update
yarncommands inCONTRIBUTINGdocument (#74)Update compatible versions in
README(#74)Tests
Revamp and fix test of Instance-Initializer
embedded(#74)Revamp and fix test of Initializer
embedded(#74)