Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ attribution/thanks for Remixicons lib #133

Merged
merged 1 commit into from
Jul 1, 2022
Merged

+ attribution/thanks for Remixicons lib #133

merged 1 commit into from
Jul 1, 2022

Conversation

clempou
Copy link
Contributor

@clempou clempou commented Jul 1, 2022

Changes description 🧑‍💻

just adding a special thanks for Remixicon + licensing info on root README

Context 🤔

Not necessarily needed for compliance but nice to have at the root

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

  • Yes
  • No

Screenshots

Phone

Tablet

Large screen

Other information

@dktbitrise
Copy link

You can download the apk here :

sample-debug.apk :
https://app.bitrise.io/app/62ac2962b2dd627a/build/ec6146c6-c253-4f9c-8857-15ba4d511991/artifact/9876509ecc67360d/p/844197b39acda85e5e4cee1f1ed0931a

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@clempou clempou merged commit 8a96991 into main Jul 1, 2022
@clempou clempou deleted the readme-remixicon-thx branch July 1, 2022 13:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauthieb lauthieb lauthieb approved these changes

@GerardPaligot GerardPaligot Awaiting requested review from GerardPaligot

@MaximeJineMaraval MaximeJineMaraval Awaiting requested review from MaximeJineMaraval

@charlottemougenot charlottemougenot Awaiting requested review from charlottemougenot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clempou @dktbitrise @lauthieb