Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material UI - OnChange text field #13970

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Material UI - OnChange text field #13970

merged 1 commit into from
Jan 18, 2017

Conversation

DenisCarriere
Copy link
Contributor

@DenisCarriere DenisCarriere commented Jan 12, 2017

Modified the signature of OnChange for the Text Field.

Please fill in this template.

  • Make your PR against the master branch.
  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run tsc without errors.
  • Run npm run lint package-name if a tslint.json is present.

Select one of these and delete the others:

If changing an existing definition:

image

End state of the code looks like this

<TextField
  hintText='Name'
  onChange={(e, value) => this.setState({name: value})}
  floatingLabelText='Name'
/>

Modified the signature of OnChange for the Text Field.
@dt-bot
Copy link
Member

dt-bot commented Jan 12, 2017

material-ui/index.d.ts

to authors (@ngbrown @herrmanno). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@mhegazy
Copy link
Contributor

mhegazy commented Jan 18, 2017

@ligaz @prashaantt @ewgenius @CarsonF and @DenisCarriere can you review this change.

@DenisCarriere
Copy link
Contributor Author

Still good on my side, but I'm the one who submitted the PR. This change is described in their docs and I've had to create a custom .d.ts file to be able to compile my typescript file when using material ui

@mhegazy mhegazy merged commit 25a0880 into DefinitelyTyped:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants