Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref lib name changed #33098

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Conversation

mehmetgelmedi
Copy link
Contributor

Updated ref types
lib.esnext.asynciterable lib name was wrong.
The reason for error is that the I character is not i in all languages.

Example when you use /// and build your project you will get the following error

node_modules/@types/node/ts3.1/index.d.ts:10:21 - error TS2727: Cannot find lib
definition for 'esnext.asyncıterable'. Did you mean 'esnext.asynciterable'?

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Feb 15, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 15, 2019

@mehmetgelmedi Thank you for submitting this PR!

🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @BrunoScheufler @smac89 @tellnes @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @matthieusieben @mohsen1 @n-e @octo-sniffle @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @ZaneHannanAU @jeremiergz @samuela @kuehlein - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 15, 2019

@mehmetgelmedi The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Contributor

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do the same change in file types/node/v10/ts3.1/index.d.ts

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed The Travis CI build failed labels Feb 15, 2019
@typescript-bot
Copy link
Contributor

@mehmetgelmedi One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 15, 2019

@mehmetgelmedi The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Contributor

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Feb 15, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot
Copy link
Contributor

@mehmetgelmedi I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

@typescript-bot typescript-bot added the Abandoned This PR had no activity for a long time, and is considered abandoned label Feb 22, 2019
@typescript-bot
Copy link
Contributor

@mehmetgelmedi To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

@Flarna Flarna mentioned this pull request Feb 22, 2019
9 tasks
@amcasey amcasey reopened this Feb 22, 2019
@amcasey
Copy link
Contributor

amcasey commented Feb 22, 2019

This change looks good. Overriding CI.

@amcasey amcasey merged commit 9a55526 into DefinitelyTyped:master Feb 22, 2019
@typescript-bot
Copy link
Contributor

I just published @types/node@11.9.5 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/node@10.12.27 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned This PR had no activity for a long time, and is considered abandoned Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants