Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@types/oracledb - Allow undefined bind parameters #38496

Merged
merged 1 commit into from
Sep 25, 2019
Merged

@types/oracledb - Allow undefined bind parameters #38496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/oracledb/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ declare namespace OracleDB {
*
* @see https://oracle.github.io/node-oracledb/doc/api.html#executebindParams
*/
type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null> | BindParameter[] | any[];
type BindParameters = Record<string, BindParameter | string | number | Date | DBObject | Buffer | null | undefined> | BindParameter[] | any[];

interface CloseConnectionOptions {
/**
Expand Down
4 changes: 3 additions & 1 deletion types/oracledb/oracledb-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ const testResultSet = async (connection: oracledb.Connection): Promise<void> =>
SELECT 2 FROM DUAL
UNION
SELECT 3 FROM DUAL`,
{},
{
test: undefined,
},
{
resultSet: true,
},
Expand Down