[meteor]: Added OptionalId<T> to insert() method. Inspired by @types/mongo

[nicu-chiciuc]

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://docs.meteor.com/api/collections.html#Mongo-Collection-insert

When trying to insert into a collection which is defined to have an _id, Typescript will err. This is change is based on the type definition for mongodb.

[nicu-chiciuc]

There seem to be some problems with union types when using Omit. The pull-request ought not to be approved until those are solved.

[typescript-bot]

@nicu-chiciuc Thank you for submitting this PR!

🔔 @barbatus @fullflavedave @orefalo @dagatsoin @birkskyum @ardatan @stefanholzapfel @andrei-markeev @lmachens @gunn @alesn @perbergland - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[nicu-chiciuc]

I've changed the definition of UnionOmit to :

type UnionOmit<T, K extends keyof any> = T extends T ? Pick<T, Exclude<keyof T, K>> : never;

Based on microsoft/TypeScript#28791 (comment)
so that union types are supported better.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#39933	diff
Batch compilation
Memory usage (MiB)	170.3	168.9	-0.8%
Type count	33968	33977	0%
Assignability cache size	54331	54328	0%
Language service
Samples taken	1096	1123	+2%
Identifiers in tests	2233	2287	+2%
getCompletionsAtPosition
Mean duration (ms)	1032.4	1034.9	+0.2%
Mean CV	7.9%	8.0%
Worst duration (ms)	1338.1	1318.1	-1.5%
Worst identifier	Meteor	absoluteUrl
getQuickInfoAtPosition
Mean duration (ms)	1028.9	1032.8	+0.4%
Mean CV	7.9%	7.6%	-4.1%
Worst duration (ms)	1232.5	1339.8	+8.7%
Worst identifier	tags	url

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@nicu-chiciuc - It appears Travis did not correctly run on this PR! /cc @RyanCavanaugh to investigate and advise.

[nicu-chiciuc]

Hi @RyanCavanaugh . The bot suggested that I /cc you and ask you to investigate and advise.

[typescript-bot]

I just published @types/meteor@1.4.35 to npm.