[react] Add crossOrigin to SVGAttributes

[icosahebron]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:

React supports SVG <image> elements with a crossOrigin prop. It even special-cases that prop so that it's rendered as an all-lowercase attribute in HTML (see facebook/react#14832).

This PR updates @types/react to reflect this, letting us write:

<image crossOrigin="anonymous"/>

instead of workarounds like:

<image {...{ crossOrigin: "anonymous" }}/>

[typescript-bot]

@icosahebron Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#40880	diff
Batch compilation
Memory usage (MiB)	126.9	123.8	-2.5%
Type count	38899	38911	0%
Assignability cache size	46651	46670	0%
Language service
Samples taken	2121	2121	0%
Identifiers in tests	2638	2642	0%
getCompletionsAtPosition
Mean duration (ms)	400.1	400.9	+0.2%
Mean CV	7.7%	7.5%
Worst duration (ms)	2701.4	2651.0	-1.9%
Worst identifier	memoized4Ref	x
getQuickInfoAtPosition
Mean duration (ms)	396.5	397.1	+0.1%
Mean CV	7.8%	7.7%	-0.5%
Worst duration (ms)	2460.4	2258.3	-8.2%
Worst identifier	ref	ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[ferdaber]

What's the purpose of the blank string as an allowed value here?

[icosahebron]

The blank string appears in the <img> equivalent:

DefinitelyTyped/types/react/index.d.ts

Line 1957 in 833391a

crossOrigin?: "anonymous" | "use-credentials" | "";

and when used as an attribute value, is treated the same as anonymous

Setting the attribute name to an empty value, like crossorigin or crossorigin="", is the same as anonymous.

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[orta]

👍

[typescript-bot]

I just published @types/react@16.9.16 to npm.