Meteor: use modern namespace for local modules

[edemaine]

Switch from old-style local module to namespace, as recommended since TypeScript 1.5.

(Originally part of #58014)

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. No additional tests needed.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://www.typescriptlang.org/docs/handbook/namespaces.html
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header. Not applicable.

[typescript-bot]

@edemaine Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• meteor — on npm, on unpkg
  • owner-approval: @radekmie

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 58020,
  "author": "edemaine",
  "headCommitOid": "6a686f981e0d40f95201aa6d9fec7c874d1760d8",
  "mergeBaseOid": "23f8e19c0212edc2a2149ef5d45656e73fffd31f",
  "lastPushDate": "2022-01-07T15:39:33.000Z",
  "lastActivityDate": "2022-01-07T19:22:02.000Z",
  "mergeOfferDate": "2022-01-07T16:55:15.000Z",
  "mergeRequestDate": "2022-01-07T19:22:02.000Z",
  "mergeRequestUser": "edemaine",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "meteor",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor/accounts-base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/blaze.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/browser-policy-common.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/check.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/ddp-rate-limiter.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/ddp.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/ejson.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/email.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/accounts-base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/blaze.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/browser-policy-common.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/check.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/ddp-rate-limiter.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/ddp.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/ejson.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/email.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/meteor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/mongo.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/random.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/session.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/tiny-test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/tools.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/globals/tracker.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/meteor.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/mongo.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/random.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/session.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/tiny-test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/tools.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/meteor/tracker.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "barbatus",
        "fullflavedave",
        "orefalo",
        "dagatsoin",
        "ardatan",
        "stefanholzapfel",
        "andrei-markeev",
        "lmachens",
        "gunn",
        "alesn",
        "perbergland",
        "nicu-chiciuc",
        "ebroder",
        "radekmie",
        "wadamek65",
        "MacRusher",
        "ToastHawaii"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2022-01-07T16:54:37.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "radekmie",
      "date": "2022-01-07T16:01:16.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1006938414,
  "ciResult": "pass"
}

[typescript-bot]

Hey @edemaine,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @barbatus @fullflavedave @orefalo @dagatsoin @ardatan @stefanholzapfel @andrei-markeev @lmachens @gunn @alesn @perbergland @nicu-chiciuc @ebroder @radekmie @wadamek65 @MacRusher @ToastHawaii — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[radekmie]

Just one minor comment about the PR description:

Switch from old-style local module to interface, as recommended since TypeScript 1.5. [...]

It's namespace, not interface.

[edemaine]

It's namespace, not interface.

Whoops, indeed! I've revised the commit message in particular to use the correct terminology. You'll need to approve again.

Can you recommend a relevant test so that your approval suffices for merge? Otherwise, I guess we wait for DT approval.

[typescript-bot]

@radekmie Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[radekmie]

Well, there’s just no way to test it. You can add an unrelated test and it’ll be enough.

[typescript-bot]

@edemaine: Everything looks good here. I am ready to merge this PR (at 6a686f9) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@barbatus, @fullflavedave, @orefalo, @dagatsoin, @ardatan, @stefanholzapfel, @andrei-markeev, @lmachens, @gunn, @alesn, @perbergland, @nicu-chiciuc, @ebroder, @radekmie, @wadamek65, @MacRusher, @ToastHawaii: you can do this too.)

[edemaine]

Ready to merge

Thanks @andrewbranch!