-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodegit Deprecated Cred and changed Clone #64571
nodegit Deprecated Cred and changed Clone #64571
Conversation
- Clone has been changed from a Class to a Function. See https://github.com/nodegit/nodegit/blob/master/examples/clone.js and https://github.com/nodegit/nodegit/tree/master/guides/cloning
- See https://github.com/nodegit/nodegit/blob/master/CHANGELOG.md#v0280-alpha1-2021-03-12 Deprecations - Note. NodeGit.Cred.sshKeyMemoryNew currently does not work. See nodegit/nodegit#1962, however NodeGit.Credential.sshKeyMemoryNew does work.
@tkmcmaster Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 64571,
"author": "tkmcmaster",
"headCommitOid": "c877650577c71d6262ce430a213e56c75e6745eb",
"mergeBaseOid": "b92231c3ef87e84860ea674ec38d8e694e5dc64e",
"lastPushDate": "2023-03-03T17:41:35.000Z",
"lastActivityDate": "2023-03-03T18:53:59.000Z",
"mergeOfferDate": "2023-03-03T18:44:29.000Z",
"mergeRequestDate": "2023-03-03T18:53:59.000Z",
"mergeRequestUser": "tkmcmaster",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "nodegit",
"kind": "edit",
"files": [
{
"path": "types/nodegit/clone.d.ts",
"kind": "definition"
},
{
"path": "types/nodegit/cred.d.ts",
"kind": "definition"
},
{
"path": "types/nodegit/credential.d.ts",
"kind": "definition"
},
{
"path": "types/nodegit/index.d.ts",
"kind": "definition"
},
{
"path": "types/nodegit/nodegit-tests.ts",
"kind": "test"
}
],
"owners": [
"dolanmiu",
"tniessen",
"pvigier",
"IGI-111",
"DaGaMs",
"julien-c",
"jmurzy",
"nikwen"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "dolanmiu",
"date": "2023-03-03T18:43:41.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1453868767,
"ciResult": "pass"
} |
Additional test data from
|
@tkmcmaster: Everything looks good here. I am ready to merge this PR (at c877650) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@dolanmiu, @tniessen, @pvigier, @IGI-111, @DaGaMs, @julien-c, @jmurzy, @nikwen: you can do this too.) |
Ready to merge |
…Clone by @tkmcmaster * Updated NodeGit.Clone to match the typings in the v0.28.0-alpha versions - Clone has been changed from a Class to a Function. See https://github.com/nodegit/nodegit/blob/master/examples/clone.js and https://github.com/nodegit/nodegit/tree/master/guides/cloning * Added NodeGit.Credential and marked NodeGit.Cred as deprecated - See https://github.com/nodegit/nodegit/blob/master/CHANGELOG.md#v0280-alpha1-2021-03-12 Deprecations - Note. NodeGit.Cred.sshKeyMemoryNew currently does not work. See nodegit/nodegit#1962, however NodeGit.Credential.sshKeyMemoryNew does work. * Fixed lint error * Added tests for Clone and Credential * Added back the LOCAL enum after confirming it's still there in 0.28.0-alpha.21
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: