-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"sshKeyMemoryNew" is not found in Typescript #1962
Comments
I'm having a different problem. Typescript does have Trying to use
So it looks like Edit: More digging, it looks like the deprecated
So there's two bugs. One is here in nodegit that |
- See https://github.com/nodegit/nodegit/blob/master/CHANGELOG.md#v0280-alpha1-2021-03-12 Deprecations - Note. NodeGit.Cred.sshKeyMemoryNew currently does not work. See nodegit/nodegit#1962, however NodeGit.Credential.sshKeyMemoryNew does work.
…aster * Updated NodeGit.Clone to match the typings in the v0.28.0-alpha versions - Clone has been changed from a Class to a Function. See https://github.com/nodegit/nodegit/blob/master/examples/clone.js and https://github.com/nodegit/nodegit/tree/master/guides/cloning * Added NodeGit.Credential and marked NodeGit.Cred as deprecated - See https://github.com/nodegit/nodegit/blob/master/CHANGELOG.md#v0280-alpha1-2021-03-12 Deprecations - Note. NodeGit.Cred.sshKeyMemoryNew currently does not work. See nodegit/nodegit#1962, however NodeGit.Credential.sshKeyMemoryNew does work. * Fixed lint error * Added tests for Clone and Credential * Added back the LOCAL enum after confirming it's still there in 0.28.0-alpha.21
@tkmcmaster I agree with you. When I was looking inside, it seemed that the namespace of the js library had been changed, but Typescript did not support it. (I used "@types/nodegit": "^0.28.2") |
…Clone by @tkmcmaster * Updated NodeGit.Clone to match the typings in the v0.28.0-alpha versions - Clone has been changed from a Class to a Function. See https://github.com/nodegit/nodegit/blob/master/examples/clone.js and https://github.com/nodegit/nodegit/tree/master/guides/cloning * Added NodeGit.Credential and marked NodeGit.Cred as deprecated - See https://github.com/nodegit/nodegit/blob/master/CHANGELOG.md#v0280-alpha1-2021-03-12 Deprecations - Note. NodeGit.Cred.sshKeyMemoryNew currently does not work. See nodegit/nodegit#1962, however NodeGit.Credential.sshKeyMemoryNew does work. * Fixed lint error * Added tests for Clone and Credential * Added back the LOCAL enum after confirming it's still there in 0.28.0-alpha.21
Probably because namespace "Cred" has changed, "sshKeyMemoryNew" is not found in Typescript.
"sshKeyNew" can be used although the following warning is issued.
I think it will probably be solved by updating the definition of Typescript.
(It worked when I directly modified the output js file)
The definition may not have been updated because it is alpha, but it is necessary for check, so please support it.
System information
The text was updated successfully, but these errors were encountered: