Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Add hash method to crypto module #69236

Closed
wants to merge 3 commits into from

Conversation

dhritzkiv
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

Add hash method introduced in 20.12.0/21.7.0
Add test for crypto.hash
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 1, 2024

@dhritzkiv Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have failed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69236,
  "author": "dhritzkiv",
  "headCommitOid": "e84346fa3cc888290806446489ed929241d29acd",
  "mergeBaseOid": "e5d07ac1d28e211291ff804adcf0d18e0002e72d",
  "lastPushDate": "2024-04-01T20:22:33.000Z",
  "lastActivityDate": "2024-04-03T12:06:05.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/crypto.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2030496246,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/e84346fa3cc888290806446489ed929241d29acd/checks?check_suite_id=22312183590"
}

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Apr 1, 2024
@typescript-bot
Copy link
Contributor

@dhritzkiv The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@dhritzkiv
Copy link
Contributor Author

dhritzkiv commented Apr 1, 2024

CI error appears to be unrelated:

serve-static failing:
Error: 
/home/runner/work/DefinitelyTyped/DefinitelyTyped/types/serve-static/index.d.ts
  4:20  error  TypeScript@4.7, 4.8, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4, 5.5 compile error: 
multer-gridfs-storage/v1 START
Cannot find module 'mime' or its corresponding type declarations  @definitelytyped/expect

@ghost
Copy link

ghost commented Apr 2, 2024

CI errors should be fixed by #69231

@ghost
Copy link

ghost commented Apr 3, 2024

Can be closed as changes have been included in #69212.

@dhritzkiv
Copy link
Contributor Author

Oops - I somehow missed that PR. Closing this one.

@dhritzkiv dhritzkiv closed this Apr 3, 2024
@dhritzkiv
Copy link
Contributor Author

@codershiba want to cherrypick my commit for test/crypto.ts? It adds crypto.hash 'tests'

1c21361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants