Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more variations of IStateService.get #7532

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Support more variations of IStateService.get #7532

merged 1 commit into from
Jan 11, 2016

Conversation

putermancer
Copy link
Contributor

Additional method signature support for angular-ui-router $state.get.

@dt-bot
Copy link
Member

dt-bot commented Jan 7, 2016

angular-ui-router/angular-ui-router.d.ts

to author (@michelsalib). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@michelsalib
Copy link
Contributor

👍

@putermancer
Copy link
Contributor Author

It got the thumbs up, and it passed the Travis CI test (though that box isn't checked for some reason). What are the next steps? Thanks for the quick work on this.

vvakame added a commit that referenced this pull request Jan 11, 2016
Support more variations of IStateService.get
@vvakame vvakame merged commit e5de4b4 into DefinitelyTyped:master Jan 11, 2016
@vvakame
Copy link
Member

vvakame commented Jan 11, 2016

thanks mate!

@putermancer putermancer deleted the IStateService.get branch January 11, 2016 19:51
someonewithpc added a commit to someonewithpc/DefinitelyTyped that referenced this pull request Aug 18, 2022
  - Make DivOverlay / Tooltip interactive (DefinitelyTyped#7531, DefinitelyTyped#7532 by @johnd0e)
  - Add openOn, close, toggle functions to DivOverlay (DefinitelyTyped#6639 by @johnd0e)
  - Introduce DomEvent.off(el) to remove all listeners (DefinitelyTyped#7125 by @johnd0e)
  - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (DefinitelyTyped#7100 by @johnd0e)
  - Add autoPanOnFocus to Marker (DefinitelyTyped#8042 by @IvanSanchez)
  - Add referrerPolicy to TileLayer (DefinitelyTyped#7945 by @natevw)
  - Add playsInline to VideoOverlay (DefinitelyTyped#7928 by @Falke-Design)
  - Add getCenter to ImageOverlay (DefinitelyTyped#7848 by @Falke-Design)
  - Fire a tileabort event when a TileLayer load is cancelled (DefinitelyTyped#6786 by @dstndstn)
  - Add crossOrigin to Icon (DefinitelyTyped#7298 by @syedmuhammadabid)
typescript-bot pushed a commit that referenced this pull request Sep 15, 2022
…ds, as of version 1.8 by @someonewithpc

* Leaflet: Update definitions to include missing methods found in 1.8

A declaration was generated with `dts-gen` and compared with the existing
definition, merging them manually to add missing methods

* Leaflet: Explicitly define `Evented.listens` with the corresponding function type and fix linter errors

* Leaflet: Add tests for added methods

* Leaflet: Add missing Mixin export

* Allow L.geoJSON to accept geojson.GeoJsonObject[], fixing #60930

* Temporarily duplicate the implementation of Events and Evented, so tests pass

* Fix toGeoJson(precision?: number | false) argument for all overrides

* Add missing properties, as pointed out by DangerBotOSS

* Add a 'tileabort' event when a tile load is cancelled

See Leaflet/Leaflet#6786

* Make changes reported in Leaflet's Changelog

  - Make DivOverlay / Tooltip interactive (#7531, #7532 by @johnd0e)
  - Add openOn, close, toggle functions to DivOverlay (#6639 by @johnd0e)
  - Introduce DomEvent.off(el) to remove all listeners (#7125 by @johnd0e)
  - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (#7100 by @johnd0e)
  - Add autoPanOnFocus to Marker (#8042 by @IvanSanchez)
  - Add referrerPolicy to TileLayer (#7945 by @natevw)
  - Add playsInline to VideoOverlay (#7928 by @Falke-Design)
  - Add getCenter to ImageOverlay (#7848 by @Falke-Design)
  - Fire a tileabort event when a TileLayer load is cancelled (#6786 by @dstndstn)
  - Add crossOrigin to Icon (#7298 by @syedmuhammadabid)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants