Update to typings of consolidate.js #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
consolidate/consolidate.d.ts to author (@soywiz). Could you review this PR? Checklist
|
horiuchi
added a commit
that referenced
this pull request
Jan 8, 2016
Update to typings of consolidate.js
|
@theosherry Thanks mate! |
someonewithpc
added a commit
to someonewithpc/DefinitelyTyped
that referenced
this pull request
Aug 18, 2022
- Make DivOverlay / Tooltip interactive (DefinitelyTyped#7531, DefinitelyTyped#7532 by @johnd0e) - Add openOn, close, toggle functions to DivOverlay (DefinitelyTyped#6639 by @johnd0e) - Introduce DomEvent.off(el) to remove all listeners (DefinitelyTyped#7125 by @johnd0e) - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (DefinitelyTyped#7100 by @johnd0e) - Add autoPanOnFocus to Marker (DefinitelyTyped#8042 by @IvanSanchez) - Add referrerPolicy to TileLayer (DefinitelyTyped#7945 by @natevw) - Add playsInline to VideoOverlay (DefinitelyTyped#7928 by @Falke-Design) - Add getCenter to ImageOverlay (DefinitelyTyped#7848 by @Falke-Design) - Fire a tileabort event when a TileLayer load is cancelled (DefinitelyTyped#6786 by @dstndstn) - Add crossOrigin to Icon (DefinitelyTyped#7298 by @syedmuhammadabid)
typescript-bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…ds, as of version 1.8 by @someonewithpc * Leaflet: Update definitions to include missing methods found in 1.8 A declaration was generated with `dts-gen` and compared with the existing definition, merging them manually to add missing methods * Leaflet: Explicitly define `Evented.listens` with the corresponding function type and fix linter errors * Leaflet: Add tests for added methods * Leaflet: Add missing Mixin export * Allow L.geoJSON to accept geojson.GeoJsonObject[], fixing #60930 * Temporarily duplicate the implementation of Events and Evented, so tests pass * Fix toGeoJson(precision?: number | false) argument for all overrides * Add missing properties, as pointed out by DangerBotOSS * Add a 'tileabort' event when a tile load is cancelled See Leaflet/Leaflet#6786 * Make changes reported in Leaflet's Changelog - Make DivOverlay / Tooltip interactive (#7531, #7532 by @johnd0e) - Add openOn, close, toggle functions to DivOverlay (#6639 by @johnd0e) - Introduce DomEvent.off(el) to remove all listeners (#7125 by @johnd0e) - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (#7100 by @johnd0e) - Add autoPanOnFocus to Marker (#8042 by @IvanSanchez) - Add referrerPolicy to TileLayer (#7945 by @natevw) - Add playsInline to VideoOverlay (#7928 by @Falke-Design) - Add getCenter to ImageOverlay (#7848 by @Falke-Design) - Fire a tileabort event when a TileLayer load is cancelled (#6786 by @dstndstn) - Add crossOrigin to Icon (#7298 by @syedmuhammadabid)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The consolidate.js type definition file was pretty out of date. I added support for the new template engines consolidate.js supports. I also added support for the various types that the supported engines can take on. For example, they return Promises if no callback is given, and the options parameter is optional.