Swap xfail for pytest.raises #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Let's wait until #36 merges, since it will be easier to fix any conflicts in this if they arise (I really doubt there will be though). |
|
hey @elbeejay, I resolved the conflicts based on Eric's numba work, and the tests pass, but there is still one xFail in shared_tools. Would you mind fixing that one while we're at it? Once you do and the tests pass again, just go ahead and merge 👍 |
amoodie
approved these changes
Jun 3, 2020
amoodie
pushed a commit
to amoodie/pyDeltaRCM
that referenced
this pull request
Feb 25, 2021
Swap xfail for pytest.raises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just flips the syntax for the few tests that were setup to x-fail so they use
pytest.raisesinstead.