mdu parameter settings not supported

[BdGraaff]

We want to change the mdu parameters in a Jupyter notebook with D-HyDAMO.

1. We want to change the settings for the 1Dsolver by using the following function:

fm.numerics.pure1d

This leads to the following error:

but we can easily acces the courant number:

and 2) We want to add a fixed weir file by using the following function:
fm.geometry.fixedweirfile

This leads to the following error:

where fm=hydrolib.core.dflowfm.mdu.models

We are using HYDROLIB version 0.2.0 and HYDROLIB-core version 0.4.1

[veenstrajelmer]

Hi @BdGraaff, thank you for creating this issue. I tried to reproduce your issue with this code:

from hydrolib.core.dflowfm import FMModel
fm = FMModel()
fm.numerics.pure1d = 1
fm.geometry.fixedweirfile = "aa"

The fixedweirfile fails since "aa" does not exist, but the property fixedweirfile is available in HYDROLIB-core. I have checked the 0.4.1 code and this property was also available back then. The keyword pure1d is missing and should be added. This is a simple fix and will hopefully be done in the near future. It is documented in the 1D2D manual

[RuudHurkmans]

Besides the keywords mentioned above, there are a few more keywords that are recommeded to set/change in the MDU but that are not included in hydrolib-core:

fm.numerics.epsmaxlev
fm.numerics.epsmaxlevm

and in geometry:

fm.geometry.storagenodefile

[MRVermeulenDeltares]

As we understand, the goal for this issue is:
add the following keyword:

• fm.numerics.pure1d
• fm.numerics.epsmaxlev
• fm.numerics.epsmaxlevm
• fm.geometry.storagenodefile

@veenstrajelmer & @rhutten is this correct?

[tim-vd-aardweg]

Let's wait until #571 is implemented @MRVermeulenDeltares

[tim-vd-aardweg]

The keywords pure1d, epsmaxlev and epsmaxlevm have been added (among with many other keywords) in #571:

model = FMModel()
    model.numerics.pure1d = 123
    model.numerics.cflmax = 12.34
    model.numerics.epsmaxlev = 12.34
    model.numerics.epsminlev = 12.34

The keywords fixedweirfile and storagenodefile were already present in HYDROLIB-core. I will therefore close this issue, but please let us know if you are having problems with these existing keywords.