Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3D header not correct #356

Merged
merged 48 commits into from
Oct 14, 2022
Merged

T3D header not correct #356

merged 48 commits into from
Oct 14, 2022

Commits on Sep 29, 2022

  1. Added ZSurf option for verticalPositionType.

    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d47cf4e View commit details
    Browse the repository at this point in the history

  2. Added a child class that inherrits from QuantityUnitPair that also ha… 

    …s a vertical position index.
    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1b48656 View commit details
    Browse the repository at this point in the history

  3. Fixed the aliases to adhere to the 2D3D manual.

    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7282233 View commit details
    Browse the repository at this point in the history

  4. Reverted Time Interpolation back to the original timeInterpolation. U… 

    …pdated testcase data to reflect the changes made to some keywords in the .bc file.
    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0e70a0a View commit details
    Browse the repository at this point in the history

  5. Added support for the timeInterpolation keyword when creating a T3D f… 

    …orcing.
    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1a1163e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Removed the QuantityUnitPositionPair class again, in favour of a bett… 

    …er design.
    @tim-vd-aardweg
    tim-vd-aardweg committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    096b2b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Fixed failing tests as a result of making the QuantityUnitPair a Base… 

    …Model instead of a NamedTuple.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    4164906 View commit details
    Browse the repository at this point in the history

  2. Added new test for the QuantityUnitPair.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    105c9e8 View commit details
    Browse the repository at this point in the history

  3. Added documentation to the VerticalInterpolation enum.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    1c05236 View commit details
    Browse the repository at this point in the history

  4. Added documentation to the TimeInterpolation enum.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    15499a9 View commit details
    Browse the repository at this point in the history

  5. Added documentation to the QuantityUnitPair class.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    91ddeef View commit details
    Browse the repository at this point in the history

  6. Updated documentation of ForcingBase to the new documentation style.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ea938a7 View commit details
    Browse the repository at this point in the history

  7. Added documenation to the T3D class.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5d691e0 View commit details
    Browse the repository at this point in the history

  8. Added validation: Ensure the first QuantityUnitPair is for time.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c37deeb View commit details
    Browse the repository at this point in the history

  9. Intermediate commit of the new validation.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    7d7a6cb View commit details
    Browse the repository at this point in the history

  10. Intermediate commit of the new validation.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b417154 View commit details
    Browse the repository at this point in the history

  11. Fixed an error in the validator and fixed formatting.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c50c71f View commit details
    Browse the repository at this point in the history

  12. Fixed some testcases and added a couple of testcases.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    735a3c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Added additional testcases

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1a10026 View commit details
    Browse the repository at this point in the history

  2. Added additional testcases

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    bbde372 View commit details
    Browse the repository at this point in the history

  3. Added additional test cases.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8d4d6f3 View commit details
    Browse the repository at this point in the history

  4. Updated reference data for T3D

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    fdebf78 View commit details
    Browse the repository at this point in the history

  5. Updated the remaining documentation for this file.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    3a44fe3 View commit details
    Browse the repository at this point in the history

  6. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    82b386a View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Fixed a bug with the number_of_verticalpositions. Implemented revie… 

    …w comments. Updated testcases.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    3e24262 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Use Vertical Position instead of verticalpositionindex

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    2cb275a View commit details
    Browse the repository at this point in the history

  2. Updated keywords for the T3D header and added a test to ensure loadin… 

    …g a .bc with T3D block works as expected.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    83c11f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Fixed code smells.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    87e78bd View commit details
    Browse the repository at this point in the history

  2. Fixed code smells.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    0694680 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Add failing testcase that should pass

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f140d80 View commit details
    Browse the repository at this point in the history

  2. Added a way to support the 'Vertical Position Specification' keyword … 

    …when reading .bc files.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    93e4f4b View commit details
    Browse the repository at this point in the history

  3. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    aee2917 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Merge branch 'main' into fix/317_t3d_header_not_correct

    @priscavdsluis
    priscavdsluis committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    72c8d49 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Updated the keywords to the new keywords.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0e1048a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/317_t3d_header_not_correct' of https://github.com/D… 

    …eltares/HYDROLIB-core into fix/317_t3d_header_not_correct
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    864ce5b View commit details
    Browse the repository at this point in the history

  3. Updated error message to be more clear

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    5489c15 View commit details
    Browse the repository at this point in the history

  4. Added backwards compatibility for the keywords in the .bc file that u… 

    …se spaces.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    88fb9fc View commit details
    Browse the repository at this point in the history

  5. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    64b972c View commit details
    Browse the repository at this point in the history

  6. Added backwards compatibility for the Time Interpolation keyword in… 

    … a [TimeSeries] block.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f64a069 View commit details
    Browse the repository at this point in the history

  7. Added error when the user forgot to specify the vertpositions field t… 

    …hat is required in the root_validator
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ae1d1a4 View commit details
    Browse the repository at this point in the history

  8. Fixed the default enum values for timeinterpolation and verticalinter… 

    …polation.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    2e6bc19 View commit details
    Browse the repository at this point in the history

  9. Removed the check for this unit as it causes problems on the build se… 

    …rver and is not super relevant.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    68a6cc5 View commit details
    Browse the repository at this point in the history

  10. Removed the ForcingBackwardsCompatibilityHelper and instead added a g… 

    …eneric root validator that can be used to rename keys.
    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    49c1575 View commit details
    Browse the repository at this point in the history

  11. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    dd24bf0 View commit details
    Browse the repository at this point in the history

  12. Update hydrolib/core/io/bc/models.py 

    Co-authored-by: Prisca van der Sluis <36264671+priscavdsluis@users.noreply.github.com>
    @arthurvd @priscavdsluis
    arthurvd and priscavdsluis committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9f55295 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Implemented review comments.

    @tim-vd-aardweg
    tim-vd-aardweg committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    5a9339a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/317_t3d_header_not_correct

    @priscavdsluis
    priscavdsluis committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6c436bd View commit details
    Browse the repository at this point in the history

  3. autoformat: isort & black

    @priscavdsluis
    priscavdsluis committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0061257 View commit details
    Browse the repository at this point in the history