T3D header not correct #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a vertical position index.
…pdated testcase data to reflect the changes made to some keywords in the .bc file.
…Model instead of a NamedTuple.
arthurvd
requested changes
Oct 5, 2022
There was a problem hiding this comment.
@tim-vd-aardweg : please see my recommendations and some questions.
veenstrajelmer
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Tested it with the testcase from #317. All reported issues are solved
…w comments. Updated testcases.
|
Implemented review comments and fixed a small bug. |
…eltares/HYDROLIB-core into fix/317_t3d_header_not_correct
… a [TimeSeries] block.
…hat is required in the root_validator
…rver and is not super relevant.
…eneric root validator that can be used to rename keys.
Co-authored-by: Prisca van der Sluis <36264671+priscavdsluis@users.noreply.github.com>
arthurvd
reviewed
Oct 13, 2022
| """VerticalPositionType: The vertical position type of the verticalpositions values.""" | ||
|
|
||
| timeinterpolation: TimeInterpolation = Field( | ||
| TimeInterpolation.linear, alias="timeInterpolation" | ||
| TimeInterpolation.linear.value, alias="timeInterpolation" |
There was a problem hiding this comment.
Here, it cannot. If we leave it out here, it will write TimeInterpolation.linear to the files.
There was a problem hiding this comment.
I find this very strange behaviour I must say 🤔
arthurvd
approved these changes
Oct 13, 2022
| @@ -462,3 +462,28 @@ def is_valid_coordinates_with_num_coordinates_specification() -> bool: | |||
| raise ValueError(error) | |||
|
|
|||
| return root_validator(allow_reuse=True)(validate_location_specification) | |||
|
|
|||
|
|
|||
| def get_key_renaming_root_validator(keys_to_rename: Dict[str, List[str]]): | |||
|
SonarCloud Quality Gate failed.
|
priscavdsluis
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317