-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3D header not correct #356
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
d47cf4e
Added ZSurf option for verticalPositionType.
tim-vd-aardweg 1b48656
Added a child class that inherrits from QuantityUnitPair that also ha…
tim-vd-aardweg 7282233
Fixed the aliases to adhere to the 2D3D manual.
tim-vd-aardweg 0e70a0a
Reverted Time Interpolation back to the original timeInterpolation. U…
tim-vd-aardweg 1a1163e
Added support for the timeInterpolation keyword when creating a T3D f…
tim-vd-aardweg 096b2b8
Removed the QuantityUnitPositionPair class again, in favour of a bett…
tim-vd-aardweg 4164906
Fixed failing tests as a result of making the QuantityUnitPair a Base…
tim-vd-aardweg 105c9e8
Added new test for the QuantityUnitPair.
tim-vd-aardweg 1c05236
Added documentation to the VerticalInterpolation enum.
tim-vd-aardweg 15499a9
Added documentation to the TimeInterpolation enum.
tim-vd-aardweg 91ddeef
Added documentation to the QuantityUnitPair class.
tim-vd-aardweg ea938a7
Updated documentation of ForcingBase to the new documentation style.
tim-vd-aardweg 5d691e0
Added documenation to the T3D class.
tim-vd-aardweg c37deeb
Added validation: Ensure the first QuantityUnitPair is for `time`.
tim-vd-aardweg 7d7a6cb
Intermediate commit of the new validation.
tim-vd-aardweg b417154
Intermediate commit of the new validation.
tim-vd-aardweg c50c71f
Fixed an error in the validator and fixed formatting.
tim-vd-aardweg 735a3c8
Fixed some testcases and added a couple of testcases.
tim-vd-aardweg 1a10026
Added additional testcases
tim-vd-aardweg bbde372
Added additional testcases
tim-vd-aardweg 8d4d6f3
Added additional test cases.
tim-vd-aardweg fdebf78
Updated reference data for T3D
tim-vd-aardweg 3a44fe3
Updated the remaining documentation for this file.
tim-vd-aardweg 82b386a
autoformat: isort & black
tim-vd-aardweg 3e24262
Fixed a bug with the `number_of_verticalpositions`. Implemented revie…
tim-vd-aardweg 2cb275a
Use `Vertical Position` instead of `verticalpositionindex`
tim-vd-aardweg 83c11f0
Updated keywords for the T3D header and added a test to ensure loadin…
tim-vd-aardweg 87e78bd
Fixed code smells.
tim-vd-aardweg 0694680
Fixed code smells.
tim-vd-aardweg f140d80
Add failing testcase that should pass
tim-vd-aardweg 93e4f4b
Added a way to support the 'Vertical Position Specification' keyword …
tim-vd-aardweg aee2917
autoformat: isort & black
tim-vd-aardweg 72c8d49
Merge branch 'main' into fix/317_t3d_header_not_correct
priscavdsluis 0e1048a
Updated the keywords to the new keywords.
tim-vd-aardweg 864ce5b
Merge branch 'fix/317_t3d_header_not_correct' of https://github.com/D…
tim-vd-aardweg 5489c15
Updated error message to be more clear
tim-vd-aardweg 88fb9fc
Added backwards compatibility for the keywords in the .bc file that u…
tim-vd-aardweg 64b972c
autoformat: isort & black
tim-vd-aardweg f64a069
Added backwards compatibility for the `Time Interpolation` keyword in…
tim-vd-aardweg ae1d1a4
Added error when the user forgot to specify the vertpositions field t…
tim-vd-aardweg 2e6bc19
Fixed the default enum values for timeinterpolation and verticalinter…
tim-vd-aardweg 68a6cc5
Removed the check for this unit as it causes problems on the build se…
tim-vd-aardweg 49c1575
Removed the ForcingBackwardsCompatibilityHelper and instead added a g…
tim-vd-aardweg dd24bf0
autoformat: isort & black
tim-vd-aardweg 9f55295
Update hydrolib/core/io/bc/models.py
arthurvd 5a9339a
Implemented review comments.
tim-vd-aardweg 6c436bd
Merge branch 'main' into fix/317_t3d_header_not_correct
priscavdsluis 0061257
autoformat: isort & black
priscavdsluis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# written by HYDROLIB-core 0.3.0 | ||
|
||
[General] | ||
fileVersion = 1.01 | ||
fileType = boundConds | ||
|
||
[Forcing] | ||
name = boundary_timeseries | ||
function = timeseries | ||
Time Interpolation = blockTo | ||
offset = 1.23 | ||
factor = 2.34 | ||
quantity = time | ||
unit = minutes since 2015-01-01 00:00:00 | ||
quantity = dischargebnd | ||
unit = m³/s | ||
0.0 1.23 | ||
60.0 2.34 | ||
120.0 3.45 | ||
|
||
[Forcing] | ||
name = boundary_t3d | ||
function = t3d | ||
offset = 1.23 | ||
factor = 2.34 | ||
Vertical Position Specification = 3.45 4.56 5.67 | ||
Vertical Interpolation = log | ||
Vertical Position Type = percBed | ||
Time Interpolation = linear | ||
quantity = time | ||
unit = m | ||
quantity = salinitybnd | ||
unit = ppt | ||
Vertical Position = 1 | ||
quantity = salinitybnd | ||
unit = ppt | ||
Vertical Position = 2 | ||
quantity = salinitybnd | ||
unit = ppt | ||
Vertical Position = 3 | ||
0.0 1.0 2.0 3.0 | ||
60.0 4.0 5.0 6.0 | ||
120.0 7.0 8.0 9.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Like this a lot :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)