Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type_enforced dependency #584

Closed
veenstrajelmer opened this issue Nov 16, 2023 · 1 comment · Fixed by #587
Closed

Remove type_enforced dependency #584

veenstrajelmer opened this issue Nov 16, 2023 · 1 comment · Fixed by #587

Comments

@veenstrajelmer
Copy link
Collaborator

What is the need for this task.
A fixed version for type_enfoced was added to fix the loose version dependency of meshkernel. Remove type_enforced dependency again after connor-makowski/type_enforced#24 is fixed or after meshkernel released a version where the version is fixed.

What is the task?
A clear and concise description of what you want to happen.

Additional context
Add any other context or screenshots about the feature request here.

@connor-makowski
Copy link

Note: This should be fixed in:

connor-makowski/type_enforced@b58d79f

type_enforced note: 1.0.0 and 1.1.0 are both yanked from pypi due to allowed installs in python 3.7 & 3.8. This should have been prevented as these python versions do not have the underlying features needed to support our new type_enforced processes.

To use python3.7 or python3.8 you must lock to type_enforced<=0.0.16. A fix is in place to function properly in 3.9+ with various restrictions related to python type hints based on exact python version (eg use of | for union typing wasn't supported by python until 3.10).

See the updated docs for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants