Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy-ribasim-qgis to github actions #1078

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

deltamarnix
Copy link
Contributor

Fixes #1067

@deltamarnix
Copy link
Contributor Author

deltamarnix commented Feb 12, 2024

@Hofer-Julian I fixed the mypy issue by changing the mypy_path. I put it in hardcoded now to see if it is working. If we want to maintain compatibility between 0.12.0 and 0.13.0 on different local machines:

  • Put both the old and the new paths in the list, mypy won't complain.
  • Do some magic mumbo jumbo with paths based on the version of pixi. There is the env_setup.bat which could look for pixi versions and change MYPYPATH env variable accordingly. It is only possible to use relative paths in MYPYPATH, so we would have to grab CONDA_PREFIX from the environment and strip off everything up to .pixi.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hofer-Julian Hofer-Julian merged commit bbd57ca into main Feb 12, 2024
21 checks passed
@Hofer-Julian Hofer-Julian deleted the feat/mypy-ribasim-qgis branch February 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mypy-ribasim-qgis and add to CI
2 participants