Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct precipitation equation #1088

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Correct precipitation equation #1088

merged 2 commits into from
Feb 9, 2024

Conversation

visr
Copy link
Member

@visr visr commented Feb 6, 2024

Before we used the current wetted area to convert the precipitation $m/s$ input to a flow rate $m^3/s$. It was deemed simpler and more stable to use the maximum profile area instead, otherwise empty Basins with 0 wetted area could never fill back up due to rain. This updates the equations to reflect that.

Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions


## Evaporation

The evaporation term is given by

$$
Q_E = E_\text{pot} \cdot A(u) \cdot \phi(d;0.1).
Q_E = E_\text{pot} \cdot A(u) \cdot \phi(d;0.1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a scientific writing course I was thought that equations in this context must be treated as part of the sentence, and so there should be a period at the end of the equation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I didn't know. I added them back. There do seems to be quite some equations without dots though.

Here $P = P(t)$ is the precipitation rate and $A$ is the wetted area. $A$ is a
function of the storage $u = u(t)$: as the volume of water changes, the area of the free water
surface may change as well, depending on the slopes of the surface waters.
Here $P = P(t)$ is the precipitation rate and $A$ is the maximum area given in the `Basin / profile` table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really the maximum area that is used? Considering

fixed_area = basin.area[i][end]

it depends on the ordering of these vectors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it depends on the ordering, but that is enforced to be increasing. We rely on these orderings in many places in the code, so I don't think an explicit max is needed.

https://deltares.github.io/Ribasim/core/usage.html#basin-profile

Except a misplaced one that breaks the quarto formatting.
@visr visr merged commit bde1e0c into main Feb 9, 2024
21 checks passed
@visr visr deleted the precip branch February 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants