Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct precipitation equation #1088

Merged
merged 2 commits into from
Feb 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions docs/core/equations.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,14 @@ plt.show()
The precipitation term is given by

$$
Q_P = P \cdot A(u).
Q_P = P \cdot A.
$$ {#eq-precip}

Here $P = P(t)$ is the precipitation rate and $A$ is the wetted area. $A$ is a
function of the storage $u = u(t)$: as the volume of water changes, the area of the free water
surface may change as well, depending on the slopes of the surface waters.
Here $P = P(t)$ is the precipitation rate and $A$ is the maximum area given in the `Basin / profile` table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really the maximum area that is used? Considering

fixed_area = basin.area[i][end]

it depends on the ordering of these vectors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it depends on the ordering, but that is enforced to be increasing. We rely on these orderings in many places in the code, so I don't think an explicit max is needed.

https://deltares.github.io/Ribasim/core/usage.html#basin-profile

Precipitation in the Basin area is assumed to be directly added to the Basin storage.
The modeler needs to ensure all precipitation enters the model, and there is no overlap in the maximum profile areas, else extra water is created.
If a part of the catchment is not in any Basin profile, the modeler has to verify that water source is not forgotten.
It can for instance be converted to a flow rate and added to a Basin as a FlowBoundary.

## Evaporation

Expand Down Expand Up @@ -192,7 +194,7 @@ MODFLOW 6 boundary conditions in the basin:

$$
Q_\text{inf} = \sum_{i=1}^{n} \sum_{j=1}^{m} \max(Q_{\mathrm{mf6}_{i,j}}, 0.0)
$$ {#eq-inf}.
$$ {#eq-inf}

Where $i$ is the index of the boundary condition, $j$ the MODFLOW 6 cell index,
$n$ the number of boundary conditions, and $m$ the number of MODFLOW 6 cells in
Expand Down
Loading