-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional 'Basin / area' spatial table #1200
Conversation
utils/templates/model.py.jinja
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this schema is not defined in Julia, I had to add it to the template here. The other two spatial schemas, Node and Edge, are also not defined there. It is slightly different in that it has a GeoSeries
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
## Basin / area | ||
|
||
The optional area table is not used during computation, but provides a place to associate areas in the form of polygons to Basins. | ||
Using this makes it easier to recognize which water or land surfaces are represented by Basins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using this makes it easier to recognize which water or land surfaces are represented by Basins. | |
Using this makes it easier to recognize which water or land surfaces are represented by basins. |
Was this intentionally capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I prefer to use capitals when referring to particular node types, to distinguish from a general drainage basin.
Fixes #960
It looks like this when loaded in QGIS:
The color is still random as I didn't implement a
renderer
yet, though that can be a follow up.I did have to take special care to make sure these polygons were not plotted on top, hiding the model.
MultiPolygons and missing polygons also work.