Add optional 'Basin / area' spatial table #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
commented
Mar 1, 2024
utils/templates/model.py.jinja
Outdated
There was a problem hiding this comment.
Since this schema is not defined in Julia, I had to add it to the template here. The other two spatial schemas, Node and Edge, are also not defined there. It is slightly different in that it has a GeoSeries.
Hofer-Julian
reviewed
Mar 1, 2024
| ## Basin / area | ||
|
|
||
| The optional area table is not used during computation, but provides a place to associate areas in the form of polygons to Basins. | ||
| Using this makes it easier to recognize which water or land surfaces are represented by Basins. |
There was a problem hiding this comment.
Suggested change
| Using this makes it easier to recognize which water or land surfaces are represented by Basins. | |
| Using this makes it easier to recognize which water or land surfaces are represented by basins. |
Was this intentionally capitalized?
There was a problem hiding this comment.
Yeah I prefer to use capitals when referring to particular node types, to distinguish from a general drainage basin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960
It looks like this when loaded in QGIS:
The color is still random as I didn't implement a
rendereryet, though that can be a follow up.I did have to take special care to make sure these polygons were not plotted on top, hiding the model.
MultiPolygons and missing polygons also work.