Use a Rust binary to expose Ribasim CLI #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- libribasim and ribasim_cli can share the same libraries - we get `ribasim.exe` instead of `ribasim.cmd`
visr
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Good to also check --version and --help
build/tests/test_models.py
Outdated
There was a problem hiding this comment.
Test non-existing TOML and --version and --help.
visr
added a commit
that referenced
this pull request
Apr 23, 2024
Follow up of #1415 --------- Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
visr
added a commit
that referenced
this pull request
Apr 29, 2024
Since LevelDemand and FlowDemand were not AbstractParameterNodes, their connections were not being validated despite the constraints being set properly. I noticed since they don't show up in the tables in https://deltares.github.io/Ribasim/core/validation.html. LinearResistance and ManningResistance already required 1 in and 1 outflow, just not in validation. Basin already cannot have outgoing control edges. Also removes an outdated comment about `ribasim.cmd`. We now only have one `ribasim.exe` since #1415.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ribasim.exeinstead ofribasim.cmd