Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Integrating discontinuous flow #1499

Merged
merged 2 commits into from
May 24, 2024
Merged

Test Integrating discontinuous flow #1499

merged 2 commits into from
May 24, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

Fixes #1498.

@SouthEndMusic SouthEndMusic changed the title Integrate discontinuous flow Test Integrating discontinuous flow May 23, 2024
Jingru923
Jingru923 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Jingru923 Jingru923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. As long as the math part is correct, here is my approval.

@visr visr merged commit c0879ca into main May 24, 2024
24 checks passed
@visr visr deleted the integrate_discontinuous_flow branch May 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jingru923 Jingru923 Jingru923 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test of mean basin forcing computation involving forcing discontinuity
3 participants
@SouthEndMusic @Jingru923 @visr