Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first check if connectivity is present in remove_unassociated_edges #474

Closed
veenstrajelmer opened this issue Jul 14, 2023 · 0 comments · Fixed by #489
Closed

first check if connectivity is present in remove_unassociated_edges #474

veenstrajelmer opened this issue Jul 14, 2023 · 0 comments · Fixed by #489

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 14, 2023 •
edited
Loading 

import dfm_tools as dfmt
file_nc = r'p:\dflowfm\maintenance\JIRA\06000-06999\06548\set_bathy_2.17.06\DFM_interpreted_network_dummy_model_net.nc'
uds = dfmt.open_partitioned_dataset(file_nc)

Raises: KeyError: 'face_node_connectivity'

This happens with minimal netfiles from interacter (or interpreted dfm files). Add testcase for these.

Also #491
@veenstrajelmer veenstrajelmer changed the title Also remove unassociated nodes first check if connectivity is present in remove_unassociated_edges Jul 18, 2023
@veenstrajelmer veenstrajelmer mentioned this issue Jul 18, 2023
Closed
11 tasks
@veenstrajelmer veenstrajelmer linked a pull request Jul 28, 2023 that will close this issue
added exception for 1D topology, including testcase #489
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added exception for 1D topology, including testcase Deltares/dfm_tools
1 participant
@veenstrajelmer