Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indirect analyses implement the same interface #315

Closed
15 tasks done
Tracked by #298
ArdtK opened this issue Mar 11, 2024 · 2 comments · Fixed by #320
Closed
15 tasks done
Tracked by #298

Indirect analyses implement the same interface #315

ArdtK opened this issue Mar 11, 2024 · 2 comments · Fixed by #320
Assignees
@ArdtK
Milestone
Architecture refa...

Comments

@ArdtK
Copy link
Contributor

ArdtK commented Mar 11, 2024 •
edited
Loading

Links to #310

  • Create indirect protocol
  • Find a way to implement the indirect analysesf 1 by 1
  • Implement factory in runner (separately) for indirect
  • Refactor analyses indirect
    • SINGLE_LINK_REDUNDANCY
    • MULTI_LINK_REDUNDANCY
    • LOSSES
    • SINGLE_LINK_LOSSES
    • MULTI_LINK_LOSSES
    • OPTIMAL_ROUTE_ORIGIN_DESTINATION
    • MULTI_LINK_ORIGIN_DESTINATION
    • OPTIMAL_ROUTE_ORIGIN_CLOSEST_DESTINATION
    • MULTI_LINK_ORIGIN_CLOSEST_DESTINATION
    • MULTI_LINK_ISOLATED_LOCATIONS
  • Port current indirect tests
@ArdtK ArdtK added this to the Architecture refactoring milestone Mar 11, 2024
@ArdtK ArdtK changed the title Indirect analyses implement the same interface Chore/Indirect analyses implement the same interface Mar 11, 2024
@ArdtK ArdtK changed the title Chore/Indirect analyses implement the same interface Indirect analyses implement the same interface Mar 11, 2024
@ArdtK ArdtK mentioned this issue Mar 11, 2024
Closed
12 tasks
@ArdtK ArdtK self-assigned this Mar 11, 2024
@ArdtK ArdtK linked a pull request Mar 11, 2024 that will close this issue
Chore/315 indirect analyses implement the same interface #317
Merged
@ArdtK ArdtK removed a link to a pull request Mar 11, 2024
Chore/315 indirect analyses implement the same interface #317
Merged
@ArdtK ArdtK linked a pull request Mar 11, 2024 that will close this issue
Chore/315 indirect analyses implement the same interface #320
Merged
@ArdtK
Copy link
Contributor Author

ArdtK commented Mar 11, 2024

Where to put logic for hazard_names_df? HazardFiles? Should not be dataclass anymore in that case.

@ArdtK
Copy link
Contributor Author

ArdtK commented Mar 11, 2024 •
edited
Loading

How to deal with analyzer = OriginClosestDestination that needs >1 graph (origins_destinations_graph, origins_destinations_graph_hazard)?

Used by

  • OPTIMAL_ROUTE_ORIGIN_CLOSEST_DESTINATION
  • MULTI_LINK_ORIGIN_CLOSEST_DESTINATION

@Carsopre Carsopre mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArdtK ArdtK

Labels
None yet
Projects
None yet
Milestone
Architecture refactoring
Development

Successfully merging a pull request may close this issue.

Chore/315 indirect analyses implement the same interface Deltares/ra2ce
1 participant
@ArdtK