-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forced logo loading in UtilityWindow Init() #344
Comments
I also have this issue |
We have the same issue. What is the current status on this issue? Thanks in advance. |
Sorry I moved this issue into the "lemme try again to make a custom package" and then got stuck. I don't understand how you are managing to have the external package work, since DOTween needs to rewrite the content of some of its files and that would render the external package useless (since rewriting those files for one project would rewrite them for all of them). Can you tell me how you dealt with this problem? |
I started with unpacking DOTween in a new project (with Modules and .asmdef). I dragged DOTween into my "Package Resources" folder within my package. I linked the DOTween modules .asmdef to my package .asmdef and my project's .asmdef. Due to DOTween UtilityWindow not working because of the forced logo loading I edited the source by simply removing the check if logos are loaded. Opened the window once. Linked the DOTween settings reference from the package to my project DOTween settings. Currently, it's a pretty "hacky" solution, but everything that I use DOTween for works as intended. If you'd like I could make a public repo with an example package for you so you can test it yourself 😁. |
There is a difference between "local" and "git url" packages. First, one could be written and could be linked with a different local path for each project. Here is some info on local packages https://docs.unity3d.com/Manual/upm-ui-local.html |
I'm creating a custom package that implements DOTween. The UtilityWindow expects the logos to be placed in the Assets folder. Due to my project being a package the root directory of the package is Library and not Assets.
I pulled the project from the master branch and changed the Init() of the DOTweenUtilityWindow by returning true if the logo couldn't be found. I've implemented the modules and the assembly definition into my package and everything is working as intended. Even the postprocessing and settings get loaded.
It seems to me that this piece of code is unnecessary and won't affect anybody if you'd remove it. It would make my life so much easier.
Thanks in advance!
The text was updated successfully, but these errors were encountered: