Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reliably probe heightmap at X,Y=0,0 #357

Open
mjml opened this issue Apr 7, 2020 · 3 comments
Open

Can't reliably probe heightmap at X,Y=0,0 #357

mjml opened this issue Apr 7, 2020 · 3 comments

Comments

@mjml
Copy link

mjml commented Apr 7, 2020

I can't use the auto-heightmap prober because my PCB bottom left edge is at X,Y=0,0. This is because I use a carved wasteboard to contain the pcb blank, and the pcb corner is right at this origin.

When I click on Probe (the button that replaces Send in edit Heightmap mode), the initial plunge at the XY origin will sometimes fail, resulting in the bit sinking into my wasteboard and missing the copper. Is there a way that I can disable that initial probe? I set the borders of my heightmap to be inset from the edges of the PCB so that I am not probing a "knife edge" of copper. I currently create the entire 6x4 heightmap manually. But I would like to create a higher resolution heightmap using the autoprober.

Can you tell me where in the code I can find this XY origin probe? I would like to experiment with disabling it, also with creating a new checkbox for it. I do not need to probe outside the bounding box. Thank you.

@mjml
Copy link
Author

mjml commented Apr 15, 2020

I found where the probe commands are issued. They are in updateHeightMapGrid() within frmmain.cpp.

@loops
Copy link

loops commented Apr 20, 2020

Just want to add support for this issue. When you define a bounding box for the heightmap operation, no probe should be done outside that box at all, including the one currently done every time at 0,0.

The whole point of creating a bounding box is to tell the operation where it can safely probe automatically. So many times I have a mounting clamp at 0,0 and this means the entire thing has to be mapped manually simply because Candle does this forced probe at 0,0.

Please remove this aspect of the heightmap operation, or at the very least make it optional.

@mjml
Copy link
Author

mjml commented Apr 20, 2020

I've implemented a checkbox for the initial probe at 0,0. It shows up in the heightmap edit mode. If you leave it unchecked, it will probe first at the bottom left corner of your grid and treat that as the Z=0 point.

I am still testing it. (It doesn't issue a G92 for this point, in other words it does not adjust your work coordinates). But if you want to try it out, it is at https://github.com/mjml/Candle in the probe-origin-option branch (forked from Experimental here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants