Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-legendary armor ornaments misrepresent the actual item rarity in the item tile #8579

Closed
mannyrye opened this issue Jul 15, 2022 · 4 comments
Labels

Comments

@mannyrye
Copy link

mannyrye commented Jul 15, 2022

DIM Version

Version 7.25.0 (release), built on 7/10/2022, 5:13:31 PM

Browser Details

All browsers

OS Details

At least iOS, MacOS and Edge on Xbox

Describe the bug

When applying an ornament made from common, uncommon or rare armor to a legendary piece of armor it makes it look like it's not legendary on DIM (it appears correctly on Destiny).
4C912525-3274-4666-A1CD-12F222CEADF0
9E58E058-AAF6-40E9-99EE-97CF3D7EF908
F1BDAA2C-6896-44DF-81B2-776037996CBC

@mannyrye mannyrye added the Bug label Jul 15, 2022
@robojumper
Copy link
Member

I don't think this can be addressed on the DIM side -- when the API generates the icons from game data it adds the blue background to the icons so that's all we have.

@robojumper robojumper changed the title Applying a common, uncommon or rare ornament to legendary armor Non-legendary armor ornaments misreprest the actual item rarity in the item tile Jul 15, 2022
@robojumper robojumper changed the title Non-legendary armor ornaments misreprest the actual item rarity in the item tile Non-legendary armor ornaments misrepresent the actual item rarity in the item tile Jul 15, 2022
@delphiactual
Copy link
Contributor

What does the item look like in the Destiny Companion App?

@mannyrye
Copy link
Author

The companion app does the same as DIM 😔 image

@bhollis bhollis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2022
@bhollis
Copy link
Contributor

bhollis commented Jul 15, 2022

We've asked the Bungie API team to change how they compose item icons to not include the background, but we have no expectation that it'll ever happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants