Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error when building latest version #115

Closed
casey opened this issue Mar 9, 2024 · 4 comments · Fixed by #116
Closed

Compile error when building latest version #115

casey opened this issue Mar 9, 2024 · 4 comments · Fixed by #116

Comments

@casey
Copy link

casey commented Mar 9, 2024

A user of just ran into a compilation error when doing cargo install just@1.25.0, see casey/just#1944. Pinning ctrlc to version 3.1.1 seems to have fixed it. I don't know if this is a ctrlc issue, a just issue, or a conflict with another dependency, but I thought I'd create an issue here.

PS Thanks for the great crate!

@kornelski
Copy link
Contributor

kornelski commented Mar 9, 2024

Same here (aarch64 macOS):

~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ctrlc-3.4.3/src/platform/unix/mod.rs:64:35
     |
64   |             let _ = unistd::close(pipe.1);
     |                     ------------- ^^^^^^ expected `i32`, found `OwnedFd`
     |                     |
     |                     arguments to this function are incorrect

Workaround:

cargo update -p ctrlc --precise 3.4.2

@fdncred
Copy link

fdncred commented Mar 9, 2024

Same problem with nushell nushell/nushell#12064 (comment).

@kornelski
Copy link
Contributor

@Detegr Could you yank the release?

@taiki-e
Copy link
Contributor

taiki-e commented Mar 10, 2024

I opened #116 to fix this, but it would still be desirable to yank the 3.4.3, even if the fix is released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants