Skip to content

Commit

Permalink
Fix gulp dev task failing when invalid scripts are saved (#2364)
Browse files Browse the repository at this point in the history
  • Loading branch information
vconst committed Dec 28, 2017
1 parent da4cf9c commit 712fd39
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion build/gulp/js-bundles.js
Expand Up @@ -59,7 +59,10 @@ var createDebugBundlesStream = function(watch) {

return gulp.src(DEBUG_BUNDLES)
.pipe(namedDebug())
.pipe(gulpIf(watch, plumber({ errorHandler: notify.onError('Error: <%= error.message %>') })))
.pipe(gulpIf(watch, plumber({
errorHandler: notify.onError('Error: <%= error.message %>')
.bind() // bind call is necessary to prevent firing 'end' event in notify.onError implementation
})))
.pipe(webpackStream(debugConfig, webpack, muteWebPack))
.pipe(headerPipes.useStrict())
.pipe(headerPipes.bangLicense())
Expand Down

0 comments on commit 712fd39

Please sign in to comment.