Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gulp dev task failing when invalid scripts are saved #2364

Merged
merged 3 commits into from Dec 28, 2017
Merged

Fix gulp dev task failing when invalid scripts are saved #2364

merged 3 commits into from Dec 28, 2017

Conversation

vconst
Copy link
Contributor

@vconst vconst commented Dec 28, 2017

No description provided.

@vconst vconst added the 17_2 label Dec 28, 2017
@vconst vconst self-assigned this Dec 28, 2017
AlekseyMartynov
AlekseyMartynov reviewed Dec 28, 2017
View reviewed changes
Copy link
Contributor

@AlekseyMartynov AlekseyMartynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's readable enough for you then LGTM

@vconst vconst merged commit 712fd39 into DevExpress:17_2 Dec 28, 2017
@vconst vconst deleted the gulp_dev_webpack_failing_17_2 branch December 28, 2017 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyMartynov AlekseyMartynov AlekseyMartynov left review comments

@kvet kvet kvet approved these changes

@DokaRus DokaRus Awaiting requested review from DokaRus

@jsdmitry jsdmitry Awaiting requested review from jsdmitry

Assignees

@vconst vconst

Labels
17_2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vconst @kvet @AlekseyMartynov