DataGrid: Fix duplicate headers when headerCellTemplate is given (T1155453) #24531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomahtri
reviewed
May 9, 2023
| const { getInstance } = this; | ||
|
|
||
| return ClientFunction( | ||
| () => (getInstance() as any).option('grouping.autoExpandAll', false), |
There was a problem hiding this comment.
minor: can we use DataGrid type from our .d.ts instead of any here?
pomahtri
previously approved these changes
May 10, 2023
williamvinogradov
previously approved these changes
May 10, 2023
Comment on lines
246
to
252
| _getContent: function(isFixedTableRendering) { | ||
| if(isFixedTableRendering) { | ||
| return this._fixedTableElement?.parent(); | ||
| } | ||
|
|
||
| return this.callBase.apply(this, arguments); | ||
| }, |
There was a problem hiding this comment.
Minor comment.
Maybe the ternary operator will be better here?
Suggested change
| _getContent: function(isFixedTableRendering) { | |
| if(isFixedTableRendering) { | |
| return this._fixedTableElement?.parent(); | |
| } | |
| return this.callBase.apply(this, arguments); | |
| }, | |
| _getContent: function(isFixedTableRendering) { | |
| return isFixedTableRendering | |
| ? this._fixedTableElement?.parent() | |
| : this.callBase.apply(this, arguments); | |
| }, |
| _removeContent: function(isFixedTableRendering) { | ||
| const $scrollContainer = this._getContent(isFixedTableRendering); | ||
|
|
||
| $scrollContainer?.length && $scrollContainer.remove(); |
There was a problem hiding this comment.
Minor comment.
Let's make this more obvious and add the if condition.
Also, it will help us in migration to TS because TS linter doesn't allow constructions like this :)
Suggested change
| $scrollContainer?.length && $scrollContainer.remove(); | |
| if($scrollContainer?.length) { | |
| $scrollContainer.remove(); | |
| } |
williamvinogradov
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://devexpress.com/issue=T1155453