This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
Improved JS codestyle according to best practices #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Crasher-ua! Thank you for the proposed codestyle changes! Will take a look as soon as possible and provide some feedback. |
tommysdk
suggested changes
Jul 28, 2017
There was a problem hiding this comment.
Basically a file reformat with explicit variable declarations which improves readability, which looks fine. There is one other pipe.js file though in webapp/themes/overview that would be in the need of the same refactoring. Do you think you could address that as well in the same pull request before merging this change?
|
Hello @tommysdk! Thanks a lot for review. Sure, I've added this file to pull request too. |
tommysdk
approved these changes
Jul 28, 2017
|
Thank you very much @Crasher-ua for your quick response and additions to the pull request! The change set looks good. |
|
Thank you @Crasher-ua for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each step of this change will makes code a little bit more consistent, changes difference
will have less size and logical problems could be revealed easier.
Commit 1: variables declaration
Commit 2: indentation
Next steps will be performed in the scope of other pull requests. In further request I want to reduce overall complexity of JS code and find logical problems if they are available.