Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

[FIXED JENKINS-27298] Prevent a stack overflow if a project eventually cycles back to itself. #96

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

christ66
Copy link
Contributor

If there is a project with downstream projects which eventually loops back to itself (cyclic projects), then it will throw a stack overflow exception. Instead we print a warning about the cyclic project, and do not add the downstream projects.

@christ66 christ66 changed the title Prevent a stack overflow if a project eventually cycles back to itself. [FIXED JENKINS-27298] Prevent a stack overflow if a project eventually cycles back to itself. Mar 10, 2015
@christ66
Copy link
Contributor Author

I created JENKINS-27298 for this bug.

@buildhive
Copy link

Diabol » delivery-pipeline-plugin #424 SUCCESS
This pull request looks good
(what's this?)

@christ66
Copy link
Contributor Author

@patbos ping?

patbos added a commit that referenced this pull request Mar 17, 2015
[FIXED JENKINS-27298] Prevent a stack overflow if a project eventually cycles back to itself.
@patbos patbos merged commit d5c22cf into Diabol:master Mar 17, 2015
@patbos
Copy link
Contributor

patbos commented Mar 17, 2015

@christ66 Thanks for the PR, I have now merged it.

@christ66
Copy link
Contributor Author

@patbos awesome! Thanks!

@christ66 christ66 deleted the circularDependency branch March 17, 2015 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants