Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Slits to ophyd-async and expand fields #384

Closed
callumforrester opened this issue Mar 15, 2024 · 5 comments · Fixed by #431
Closed

Port Slits to ophyd-async and expand fields #384

callumforrester opened this issue Mar 15, 2024 · 5 comments · Fixed by #431
Labels
enhancement New feature or request

Comments

@callumforrester
Copy link
Contributor

callumforrester commented Mar 15, 2024

Inspired by #377

An ophyd-async version of Slits is required for the upcoming I22 experiment in June 2024 in order to populate the NeXus file with relevant metadata. It seems sensible to port the existing version into an ophyd-async class that remains compatible with hyperion rather than create two devices.

Additional fields need to be added to populate the NeXus file correctly (see below)

Acceptance Criteria

  • The following ophyd devices are ophyd-async: S4SlitGaps
  • Slits config available in i22 beamline module
  • Fake slits config available in p38 beamline module
  • @DominicOram and the hyperion team are happy with their compatiblity
  • The attributes required by the NeXus files are exposed: X_centre, Y_centre, X_size, Y_size
@callumforrester callumforrester added the enhancement New feature or request label Mar 15, 2024
@callumforrester
Copy link
Contributor Author

Assumption to be confirmed is that I22 slits are the same as I03 slits, or at least that the IOCs can be modified to have the same naming conventions.

@callumforrester
Copy link
Contributor Author

Have just realised there's no overlap in fields needed by I22 and hyperion

  • Hyperion
    • xgap
    • ygap
  • I22
    • X_centre, Y_centre, X_size, Y_size

so two options:

  1. Have one device with all fields, extra config to customise output of .read()
  2. Have two devices

Any thoughts @DominicOram or @olliesilvester?

@DominicOram
Copy link
Contributor

DominicOram commented Mar 15, 2024

Ok, had a chat to controls, xgap is the same as X_size but PVs are annoyingly not standard. We will ask them to move to the I22 standard given that the other slits on i03 use this standard. So have two devices for now, we will move when we have the standard. However, I still don't think these slits will have individual blade control so we may need the common device to have that as optional

@DominicOram
Copy link
Contributor

FYI https://jira.diamond.ac.uk/browse/I03-956

@DominicOram
Copy link
Contributor

I think we should be able to switch to these by the time they're written, controls are making the changes now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants