Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2) Move devices in from Artemis #17

Merged
merged 823 commits into from
Mar 6, 2023
Merged

(#2) Move devices in from Artemis #17

merged 823 commits into from
Mar 6, 2023

Conversation

noemifrisina
Copy link
Collaborator

No description provided.

DominicOram and others added 30 commits November 29, 2022 18:09
…ource/318_oav_centring_create_devices_for_oav_set_values_at_start_of_operation

318 oav centring create devices for oav set values at start of operation
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ource/318_oav_centring_create_devices_for_oav_set_values_at_start_of_operation

318 oav centring create devices for oav set values at start of operation
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ource/318_oav_centring_create_devices_for_oav_set_values_at_start_of_operation

318 oav centring create devices for oav set values at start of operation
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
identified by random order testing :)
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ource/fix_smargon_import

fix old import in oav centring
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ource/391_ispyb_interaction_and_comment

391 ispyb interaction and comment
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ds to load display configuration and xml camera zoom levels.

NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ds to load display configuration and xml camera zoom levels.

NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ds to load display configuration and xml camera zoom levels.

NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ds to load display configuration and xml camera zoom levels.

NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
…ource/413_systematize_callbacks

413 systematize callbacks
NOTE: Commit originally came from https://github.com/DiamondLightSource/python-artemis
@DominicOram
Copy link
Contributor

Added @callumforrester for comment but I'm keen to see this merged ASAP to avoid continually keeping it up to date with Artemis changes. If you have some comments we can address in further issues/PRs, if that's ok?

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be able to tidy up the utils but can leave that for a later PR. Happy to merge.

@DominicOram DominicOram merged commit 9177695 into main Mar 6, 2023
@DominicOram DominicOram deleted the add-code-from-artemis branch March 6, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants